https://pantsbuild.org/ logo
#development
Title
# development
w

witty-crayon-22786

10/21/2022, 8:10 PM
@sparse-lifeguard-95737, @bitter-ability-32190, @ancient-vegetable-10556: so! i think that you all have the largest (pending?) changes targeted for 2.15.
it sounds like Chris might have his stuff mostly in sometime early next week
b

bitter-ability-32190

10/21/2022, 8:11 PM
🫡
w

witty-crayon-22786

10/21/2022, 8:11 PM
i don’t actually know what is pending for
fmt
/
lint
/
fix
… just docs at this point…?
a

ancient-vegetable-10556

10/21/2022, 8:11 PM
@bitter-ability-32190 I may well have questions for you about the internals/intent behind partitioning, which I’m saving for Monday
👍 2
This is the context, with a bunch of relevant PRs linked: https://github.com/pantsbuild/pants/issues/17129
s

sparse-lifeguard-95737

10/21/2022, 8:14 PM
the test-batching work took a detour to iterate on the generic partitioning API - the hairiest API change (I hope) merged today, unblocking https://github.com/pantsbuild/pants/pull/17255. once 17255 merges I plan to update https://github.com/pantsbuild/pants/pull/17134 (core
test
goal impl) to use the new generic APIs
a

ancient-vegetable-10556

10/21/2022, 8:15 PM
a generic partitioning API? oooooh
s

sparse-lifeguard-95737

10/21/2022, 8:16 PM
and once the core
test
changes are merged, I will follow up with the actual batched
pytest
implementation 😅
w

witty-crayon-22786

10/21/2022, 8:16 PM
cool beans… so maybe that is the long pole…?
a

ancient-vegetable-10556

10/21/2022, 8:16 PM
we should probably make sure the needs of the environments work is met by the partitioning API
b

bitter-ability-32190

10/21/2022, 8:17 PM
So on the docket are my pending PRs. I don't think I'll get to adding new features in 2.15.x past those. 2.16.x might see a pants.toml fixer and a "generic" prettier targetless support 🤓
Then another docs pass for 2.15
(Symlinks aren't a blocker)
w

witty-crayon-22786

10/21/2022, 8:17 PM
So on the docket are my pending PRs.
which? maybe worth marking them with the
2.15.x
Milestone
b

bitter-ability-32190

10/21/2022, 8:19 PM
Done
I flagged the
external_tools
because I wanna blog about it 😈
s

sparse-lifeguard-95737

10/21/2022, 8:19 PM
@witty-crayon-22786 I expect that I can get the core
test
changes out of “draft” mode on Monday, maybe even merged depending on what comes out in reviews. and then get the batched
pytest
PR up the next day (I’ve been playing with it locally and don’t expect it to be too complex)
👍 1
b

bitter-ability-32190

10/21/2022, 10:22 PM
I think I'm the blocker but I got a busy weekend 😅
w

witty-crayon-22786

10/21/2022, 10:23 PM
yea, don’t worry about it: there is no actual time pressure until someone decides they want to land something else on top of all of this and we need to start saying no
b

bitter-ability-32190

10/21/2022, 10:29 PM
I think symlinks are too risky to land in 2.15. but the current PR is such that no one should hit that code in the wild
w

witty-crayon-22786

10/21/2022, 10:30 PM
yea, that seems like a great thing to wait
b

bitter-ability-32190

10/21/2022, 10:30 PM
The following PR that actually wires it up should wait
w

witty-crayon-22786

10/25/2022, 10:20 PM
@ancient-vegetable-10556, @sparse-lifeguard-95737, @bitter-ability-32190: how is all of this looking?
would be great to be able to cut in the next few days
b

bitter-ability-32190

10/25/2022, 10:30 PM
I need to deprecate uodate-build-files. Will post tomorrow. Then 2.15 is good to go for me
🎉 1
s

sparse-lifeguard-95737

10/25/2022, 10:53 PM
My PR for the generic batched test plumbing is up for review now. I have a couple fast-follows for TODOs in that, and then the actual “batched pytest” implementation that I’ll work on tomorrow
(https://github.com/pantsbuild/pants/pull/17134 is the PR generic plumbing PR blocking the rest)
w

witty-crayon-22786

10/25/2022, 10:59 PM
sounds good… yea, anything that isn’t in before the branch cut will need to be cherry-picked… but it sounds like maybe some of the fast-follow stuff could be picked (or not, if they can wait for 2.16.x?)
let me know if i can help review anything.
s

sparse-lifeguard-95737

10/25/2022, 11:12 PM
The “fast follow” stuff is already done on branches, I just haven’t figured out how to stack PRs across forks 😅
(They are user-facing API changes I don’t want to mix with the plug-in API change)
I’ve wondered about waiting on the pytest-batching - is it possible to “override” the definition of a rule by redefining a rule with the same types?
If so we could experiment with the actual batched pytest logic before upstreaming it
(Though, I expect it won’t be much work to make the PR directly tomorrow)
w

witty-crayon-22786

10/25/2022, 11:22 PM
is it possible to “override” the definition of a rule by redefining a rule with the same types?
not currently, no: would need to be able to “uninstall” the existing rule before adding the replacement. we’ve discussed that (and i think that it is trivial to do?), but i can’t find the ticket for it…
hey gang! today is the day! (?) what’s outstanding for 2.15.x?
b

bitter-ability-32190

10/28/2022, 4:27 PM
Before the release we should fix the python run goal, but doesn't can be cherry picked
s

sparse-lifeguard-95737

10/28/2022, 4:30 PM
I just opened https://github.com/pantsbuild/pants/pull/17385 as a draft to get review rolling - working on tests now
https://github.com/pantsbuild/pants/pull/17361 needs updated but should be a quick turn-around, will knock it out in a few minutes
w

witty-crayon-22786

10/28/2022, 4:58 PM
ah, thanks: sorry, had missed your other thread update
s

sparse-lifeguard-95737

10/28/2022, 6:44 PM
pushed some tests to https://github.com/pantsbuild/pants/pull/17385 and took it out of draft mode!
going to file a separate issue for the docs
w

witty-crayon-22786

10/28/2022, 6:49 PM
thanks: looking now. cc @hundreds-father-404
h

hundreds-father-404

10/28/2022, 6:57 PM
thanks, pairing and won't be able to take a look at things right now
👍 1
w

witty-crayon-22786

10/28/2022, 7:10 PM
@sparse-lifeguard-95737: i don’t really see any blockers there, so when you’re ready, let me know and i’ll (set auto-)merge
s

sparse-lifeguard-95737

10/28/2022, 7:12 PM
It’s ready as far as I know 😄
Ah I see your comments came through - let me take a look through…
@witty-crayon-22786 sorry, I keep stepping on the auto-merge - I pushed one more commit to have pytest partition by environment (I think eventually we don’t want plugins to need to think about environments? but for now it’ll avoid a class of error). I promise I’m done pushing to the branch now 🙂
so close I can taste it - one of the CI shards hit a flaky failure, can somebody poke it?
w

witty-crayon-22786

10/28/2022, 9:10 PM
yep
huzzah! ok folks: it seems like we can cut
2.15.0a0
and
2.15.x
? we can of course continue to cherry-pick, but if there is anything that is already in the queue to land that i should wait for, let me know.
ok @sparse-lifeguard-95737: now you can go on vacation (again)
🌴 1
c

curved-television-6568

10/28/2022, 9:58 PM
I think this one would be good to land in 2.15.x https://github.com/pantsbuild/pants/pull/17330
👍 1
cp is of course an option too
w

witty-crayon-22786

10/28/2022, 10:02 PM
@curved-television-6568: 🚢 with minor fixes: thanks!
🙏 2
c

curved-television-6568

10/28/2022, 10:03 PM
thanks! 🙂
w

witty-crayon-22786

10/28/2022, 10:03 PM
i’ll assume that that lands, and include it in the prep.
👍 1
c

curved-television-6568

10/28/2022, 10:04 PM
enabled auto-merge..
feel free to make it go through if there’s any hicups
w

witty-crayon-22786

10/28/2022, 10:06 PM
hey folks! please talk with me before merging anything else to
main
until the release prep has landed in https://github.com/pantsbuild/pants/pull/17392
h

happy-kitchen-89482

10/29/2022, 1:15 AM
Och, I screwed up and merged 17393 right before you merged this prep, sorry! But it’s internal, so doesn’t change the changelog
So I think you don’t need to redo anything?