<oops> Will fix this ASAP
# developmentb
bitter-ability-32190
11/10/2022, 5:33 PMoops Will fix this ASAP
👍 1
h
hundreds-father-404
11/10/2022, 5:33 PMalso on us for bad code review
b
bitter-ability-32190
11/10/2022, 5:33 PMFound this using
./pants_from_sourcesbitter-ability-32190
11/10/2022, 5:34 PMI mean the review was very large, and some `todo`s werevalid can-kicking
bitter-ability-32190
11/10/2022, 5:40 PMhttps://github.com/pantsbuild/pants/pull/17523
CC @witty-crayon-22786
w
witty-crayon-22786
11/10/2022, 5:43 PMand some `todo`s werevalid can-kickinghm… yea, sorry i missed that. we should definitely not use `todo!`s for TODOs that we’re committing in the future, because panics are a way worse user experience than errors
b
bitter-ability-32190
11/10/2022, 5:51 PMIn reality we probably could've just addressed this in PR.
w
witty-crayon-22786
11/10/2022, 6:03 PMyea, s’all good