https://pantsbuild.org/ logo
#development
Title
# development
b

bitter-ability-32190

11/10/2022, 5:33 PM
oops Will fix this ASAP
👍 1
h

hundreds-father-404

11/10/2022, 5:33 PM
also on us for bad code review
b

bitter-ability-32190

11/10/2022, 5:33 PM
Found this using
./pants_from_sources
I mean the review was very large, and some `todo`s werevalid can-kicking
w

witty-crayon-22786

11/10/2022, 5:43 PM
and some `todo`s werevalid can-kicking
hm… yea, sorry i missed that. we should definitely not use `todo!`s for TODOs that we’re committing in the future, because panics are a way worse user experience than errors
b

bitter-ability-32190

11/10/2022, 5:51 PM
In reality we probably could've just addressed this in PR.
w

witty-crayon-22786

11/10/2022, 6:03 PM
yea, s’all good