https://pantsbuild.org/ logo
#development
Title
# development
w

worried-painter-31382

03/07/2023, 8:35 AM
I am encouraged by the contributor guide to ping regarding https://github.com/pantsbuild/pants/pull/18417, it is preparatory work for https://github.com/pantsbuild/pants/issues/16959, but intend only minor functional changes
a

ancient-vegetable-10556

03/07/2023, 4:29 PM
@worried-painter-31382 Thanks for the changes here! If you’re looking at improving our JS support, I’d also encourage you to look at https://github.com/pantsbuild/pants/issues/14492 — currently
system_binary
makes use of a hard-coded list of search paths, which makes it hard to use the
system_binary
and
adhoc_tool
targets to use
node
binaries that are installed in weird locations.
w

worried-painter-31382

03/07/2023, 5:23 PM
Thanks! While I understand the issue, my current focus is to try and bring javascript language support, so
adhoc_tool
focused tasks I think I'll politely bow out of in favor of tasks that are discussed here https://github.com/pantsbuild/pants/discussions/17357 which continues on from https://github.com/pantsbuild/pants/pull/18326.
a

ancient-vegetable-10556

03/07/2023, 5:23 PM
OK, good luck!