As mentioned previously somewhere, GitHub has depr...
# development
f
As mentioned previously somewhere, GitHub has deprecated
dependabot.yml
for configuring Dependabot reviewers and will instead use
CODEOWNERS
. But
CODEOWNERS
has no way to restrict to just Dependabot. Thus, if we had
**/Cargo.toml
and
src/rust/engine/Cargo.lock
in the configuration, then any changes to those files will have the reviewers added, not just Dependabot PRs. This may be fine, but an alternative may be to have an GitHub Actions workflow to assign reviewers instead whenever a Dependabot PR is opened. Thoughts?
I'm inclined to the GHA workflow approach since it side steps us having to figure out what we want in
CODEOWNERS
(given the effects with regular PRs).
w
So, generally okay with anything here - but one note that might be handy... I've occasionally noticed PRs which languish due to no reviewers, and in some of these cases it might be because the pr creator just doesnt know who to add by default. That might speak to the need for a codeowners too?
f
And which point we restart the debate over what
CODEOWNERS
should be in general and who is assigned to what.
I'm intentionally restricting the scope of this question to how to deal with the
dependabot.yml
deprecation.
The more general question is important, but it is more tractable to solve the deprecation first.
w
fair - so i guess the discussion would be more about... do we want automated dependabot reviewers or not. Assuming yes, is there another option excluding codeowners - other than GHA? If GHA is the only real option - seems like the right approach
Although - the people who could review a dependabot change would probably be the same people involved in changes to cargo.toml/lock as well 😄
c
I also think having no default reviewers would be not-ideal-but-acceptable to avoid extra work. (I think that is how it was for along time)
f
We wouldn’t need a no reviewers default though. The proposed alternative is a GHA workflow to assign reviewers versus having it done by having configured by
CODEOWNERS
So if there is no objection to the workflow, I can set that up.