Is there a preferred approach to profiling rust on osx? I see some old messages recommending Instruments but I'm not really familiar with using that. I found https://github.com/tikv/pprof-rs which looks interesting, would integrating something like this into pants be helpful to others? In theory this can ship with pants so users could profile using a cli flag and output a flame graph

Assuming it doesn’t materially add to the build time of the engine, it could be a good idea. Although we try to be parsimonious in adding 3rdparty deps since every one is a vector for a supply chain attack.

Oh, I have opinions all right… We’re already rocking about 60 cargo deps - so there’s that 😆 I haven’t dug into that specific library, but a couple thoughts: • Does that have any impact on runtime when it’s not in use? In my experience, profilers need to do a bunch of instrumentation, so can that be noop’d at runtime with a flag? • Does this open us up to “what about adding Profiler XYZ”? • Once it gets added and then exposed to a CLI, it’s basically a permanent fixture to Pants • What set of feature flags would we ship our binary with (I’m not entirely sure if pprof’s “features” are compile time or strictly runtime)? The pros/cons list on pprof wasn’t really convincing for me, but I do think there is a world where we have a feature gated profiling mode - which doesn’t ship with the Pants binary, but makes it easier to build from source with profilers integrated 🤷

That guide has been helpful to me, definitely appreciate the work that went into it. My recollection of trying py-spy on osx was that native profiling didn't work. (I can dig up the issue if anyone is curious) Which is how I started looking for other ways to do this that didn't involve swapping my workstation out

Maybe it was py-spy for me, or I thought that one wanted sudo (which I don't give anything on my primary machine)