fast-nail-55400
02/12/2025, 5:40 AM% ./pants run src/python/pants_release/release.py -- test-release
[=== 00:01 Installing and testing the latest released packages ===]
00:36:30.62 [INFO] waiting for pantsd to start...
00:36:32.48 [INFO] pantsd started
00:36:32.61 [INFO] Initializing scheduler...
00:36:36.38 [INFO] Scheduler initialized.
2.25.0a1
Failed to confirm pants version, expected '2.25.0a1', got ''
3. Instructions need to updated to no longer talk about PyPI publishing and also need to add a mention of the PR generated for the documentation site.broad-processor-92400
02/12/2025, 6:06 AMPANTS_NO_NATIVE_CLIENT=1 ./pants ...
broad-processor-92400
02/12/2025, 6:08 AM1. After running Step 2 in the release process to tag the release, the GitHub release is not created in draft mode and then promoted. Instead, it is created as released and announced as soon as the Release GHA workflow completes. Is this intentional?I think it's created by the release workflow in draft mode and then undrafted/published once all artifacts are attached (as part of the final automatic publish step): • https://github.com/pantsbuild/pants/blob/dd87b85b1101414409cba0060feb505392b13797/src/python/pants_release/generate_github_workflows.py#L1188 • https://github.com/pantsbuild/pants/blob/dd87b85b1101414409cba0060feb505392b13797/src/python/pants_release/generate_github_workflows.py#L1286 That seems intentional to me. Do you have some alternatives in mind?
fast-nail-55400
02/12/2025, 8:09 AMDo you have some alternatives in mind?I'd suggest we create release in draft mode so we can run the smoke tests (and the public repo testing). The announcement workflow should move to a job which triggers when the release is finally taken out of draft mode.
fast-nail-55400
02/12/2025, 8:14 AMfast-nail-55400
02/12/2025, 8:15 AMhappy-kitchen-89482
02/12/2025, 6:47 PMhappy-kitchen-89482
02/12/2025, 6:48 PMfast-nail-55400
02/12/2025, 6:58 PMfast-nail-55400
02/12/2025, 6:59 PMhappy-kitchen-89482
02/12/2025, 8:08 PMfast-nail-55400
02/12/2025, 8:31 PMfast-nail-55400
02/12/2025, 8:32 PMfast-nail-55400
02/12/2025, 8:33 PMfast-nail-55400
02/12/2025, 8:34 PMbroad-processor-92400
02/12/2025, 9:50 PMI'd suggest we create release in draft mode so we can run the smoke tests (and the public repo testing). The announcement workflow should move to a job which triggers when the release is finally taken out of draft mode.Ah, I see. Sounds plausible in theory 👍 although I think that'd be a bit awkward, because a draft release is "private" / requires authing with sufficient privileges to install? (I think?) Our convention of always doing an rc before a stable release (i.e. a stable release has the same code (other than version) as the most recent rc) gives a lot of the benefits. It's seems relatively unproblematic for non-stable releases to be broken, especially as it lets us have a more automated release flow with less required human interaction. 🤔 definitely worth thinking about potential improvements though!
fast-nail-55400
02/12/2025, 9:57 PMcrater
runs?fast-nail-55400
02/12/2025, 9:59 PMbroad-processor-92400
02/12/2025, 10:07 PMbroad-processor-92400
02/12/2025, 10:47 PMfast-nail-55400
02/12/2025, 11:01 PM