Hey folks, what are our thoughts on sharing fields between plugins? I'm adding Trivy as a linter for Helm and the

kubernetes_version

is almost certainly the same between

kubeconform

and

trivy

. Does anyone have a practical or moral objection to me pulling that field into common Helm things and using it in both plugins?

I dont use Helm, but when you say “almost certainly”, how almost are we looking at?

I honestly cannot imagine a case when you'd want them to be different. I think setting these differently would be indescribably cursed, but that won't stop someone from trying it like https://xkcd.com/1172/

Yeah, this might be a domain expert thing. If it’s genuinely a rare/broken event - then maybe starting off sharing them makes sense until someone complains?

Maybe this can all go in the same backend? I feel like we have way too many of them

Each of these requires its own standalone tool, doesnt it?

Yes, but backends can support multiple tools

Yeah both of these will be in the Helm backend. Trivy is multi-backend so common code will be in the tools folder

Is that what we're talking about @happy-kitchen-89482 I thought you meant those tools would all be part of a single backend?

I was wondering if the common helm things and trivy could all live in the existing helm backend. But if trivy is more general then I guess not.

Trivy is a scanner for secrets, infra misconfiguration (terraform and helm), and docker images. I've put the general trivy rules in tools, and the rules specific to each backend in a folder in that backend.