If anyone wants some straightforward code reviews ...
# development
f
If anyone wants some straightforward code reviews to do, I have a few Rust crate upgrades in flight which need review: •
serde
and friends: https://github.com/pantsbuild/pants/pull/21437 • `bytes`: https://github.com/pantsbuild/pants/pull/21436
tokio
and friends: https://github.com/pantsbuild/pants/pull/21435
h
I didn’t see a corresponding Cargo.toml change in these PRs?
f
cargo update
does not do that.
the newer versions are still compatible with versions appearing in the
Cargo.toml
what's the best practice for Rust crate version locking?
for example, some versions are more specific (e.g.,
bytes = "1.5"
, others are more general
http = "1"
and would not need to be updated in
Cargo.toml