https://pantsbuild.org/ logo
Join Slack
Powered by
my MOTW is coming to a close. I wasn't successful ...
# development
b
my MOTW is coming to a close. I wasn't successful at getting 2.18.2 or 2.19.0 out: they're current blocked by resolving some minor hitches with the new website/docs: • 2.20.0.dev7: https://github.com/pantsbuild/pants/pull/20410; prepared for convenience in case it's useful for validating the doc syncing. • 2.19.0rc5: https://github.com/pantsbuild/pants/pull/20402 intended to be just doc changes/validating the sync to the new doc site, with 2.19.0 essentially immediately after... felt like validating the behaviour of the new flow on a non-main branch with a immediate .0 stable release was a bit too brave • 2.18.2: https://github.com/pantsbuild/pants/pull/20396 assuming all the required doc updates make it into 2.18.x and the validations above work, this seems ready for cutting
❤️ 2
b
FWIW I think we could do releases like normal, and if the docs sync fails (or has unexpected consequences) that's ok. It isn't hard to remedy that situation and I'd hate to delay a major release on something as inconsequential
h
I'm MOTW so I'll take these up
thanks!
@bitter-ability-32190 can you clarify how the docs repo interacts with versioning, i.e., how to publish docs for 2.x when 2.x is released? Also is https://www.pantsbuild.org/2.18/docs/contributions/releases/release-process#step-2-update-this-docs-site still current?
b
There's a GitHub action that handles the syncing. It just needs to be triggered (which will be automatic at some point)
The release instructions aren't current. I haven't had a chance to update them, but it's on the list of follow-up work
b
Action that can be triggered manually: https://github.com/pantsbuild/pantsbuild.org/actions/workflows/sync_docs.yml NB. it's currently not working because it needs @WorkerPants to have permission to open a PR to that repo: https://github.com/pantsbuild/pantsbuild.org/issues/114 (I think Josh and I aren't able to set this up)
h
I may have fixed that issue, I guess we'll find out.
🤞 2
Copy code
! [rejected]        automation/sync-2.20.0.dev6 -> automation/sync-2.20.0.dev6 (non-fast-forward)
error: failed to push some refs to '<https://github.com/pantsbuild/pantsbuild.org>'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. If you want to integrate the remote changes,
hint: use 'git pull' before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
b
Ah, right, the previous run would've created a branch and we didn't clean it up
h
I'll clean it up manually for now
b
ah, i just did it
and hit the retry
h
🙏
b
Nice 🎉 PR creation seemed to work: https://github.com/pantsbuild/pantsbuild.org/pull/119 There's lots of changes to the reference and no changes to the docs... I would've expected us to at least see https://github.com/pantsbuild/pantsbuild.org/pull/116 be reverted in the 
docs/docs
directory?
Thoughts @bitter-ability-32190?
b
😔
Did you re-run it? If so I wonder if it's using the original runs GOTHIB_REF which would've been before my change
h
Yeah, this was a rerun of an old PR
b
It logs the commit in the run, we can easily check
'fc93a86578dc81a31df713f90c854f637379e985'
Yes 
fc93...
is "Collapse "overview" pages", which is before the header change
b
Ah, so it’s just a consequence of GitHub’s diff? I guess we should close/delete that branch and try again from scratch?
b
It's a consequence of timing and re-run semantics
But yeah let's purge and re-run with new trigger
h
I'll rerun with the new releases anyway
3 Views
Open in Slack
PreviousNext
Powered by