Have a few things that will benefit from feedback:...
# development
l
Have a few things that will benefit from feedback: • https://github.com/pantsbuild/pants/pull/20122 env var pass through for docker environments. Got feedback from Andreas and Stu and addressed it before I disappeared, but would like to get it out and possibly pick something else up relating to environments. • https://github.com/pantsbuild/pants/pull/20255 is a DRY between
code_quality_tool
and
adhoc_tool
. Daniel caught an error, and it is fixed now, but it will benefit from review from someone else familiar with adhoc_tool. • We're ready to take on the design discussion around the ergonomics part 2 of code_quality_tool which is needed before we announce it. I've summarized some of the proposals around it in https://github.com/pantsbuild/pants/issues/17729#issuecomment-1843036540
👍 1
If I can get another +1 in the direction that Andreas suggested in this comment (or the slight variant here) I'll start exploring the implementation of how to get that to work with subsystem/option loading. I think it will be a nice way to do it.