I'm having trouble understanding the intended con...
# development
c
I'm having trouble understanding the intended consistency of INFO. From
pants lint
on an internal repo:
Copy code
16:45:09.59 [INFO] Completed: Lint Helm charts - helm succeeded.
Partition: cron-ingest-snowflake
16:45:09.59 [INFO] Completed: Lint Helm charts - helm succeeded.
Partition: cron-ingest-yes-series
16:45:09.59 [INFO] Completed: Lint Helm charts - helm succeeded.
Partition: cron-ingest-rds
16:45:09.59 [INFO] Completed: Lint Helm charts - helm succeeded.
Partition: cron-ingest-feast
16:45:11.95 [INFO] Completed: Lint with Hadolint - hadolint succeeded.
16:45:12.00 [INFO] Completed: Lint with Flake8 - flake8 succeeded.
Partition: ['CPython==3.10.*']
16:45:12.00 [INFO] Completed: Format with isort - isort made no changes.
16:45:12.00 [INFO] Completed: Format with Black - black made no changes.
16:45:12.01 [INFO] Completed: Format with Black - black made no changes.
16:45:12.01 [INFO] Completed: Format with Black - black made no changes.
16:45:12.08 [INFO] Completed: Fix with pyupgrade - pyupgrade made no changes.
• Why does
Partition:
not have a timestamp/log level? • What is a user supposed to understand from
Completed: Format with Black - black made no changes.
3 times in a row?
c
• I think that the “Partition” line is part of the previous log entry, indentation would’ve been good to make this more clear. • Black logs are for batched jobs… see: https://github.com/pantsbuild/pants/issues/15139
c
The
Partition
looks like a hard newline https://github.com/pantsbuild/pants/blob/main/src/python/pants/core/goals/lint.py#L97 I guess I usually expect logs one per line, and anything else as "someone left in a
print
2
h
Yeah, that hard newline is confusing and we should probably kill it
Maybe we should add (Batch #X of Y) to the Completed lines
1