broad-processor-92400
11/03/2023, 2:25 AMgorgeous-winter-99296
11/03/2023, 8:17 AMtar issue. However, with the abysmal repro rate I'm not sure if it'd be worth it as a last second thing. Assuming the only reason that can actually occur is due to hardlink counters, we can just disable the warning. However, I think it could also occur if the file is flushed to disk after the sandbox is started, so we have a sequence of
1) Sandbox A runs, producing Large Artifact
2) Pants captures large artifact, and writes to cache as LA'
3) Sandbox B starts running, using a hardlink to LA'
4) The kernel flushes LA' to disk
5) Tar blows up because ctime changedgorgeous-winter-99296
11/03/2023, 8:24 AM--warning=no-changed-file which as mentioned is only correct if we know that the file actually cannot change)broad-processor-92400
11/03/2023, 9:59 AM--warning=no-changed-file(That may be a GNU tar-only option, and not available in, for instance, macOS's default tar. Just to make life "easy".)
gorgeous-winter-99296
11/03/2023, 9:59 AMcurved-television-6568
11/03/2023, 1:48 PMhappy-kitchen-89482
11/03/2023, 2:28 PMhappy-kitchen-89482
11/03/2023, 2:28 PMhappy-kitchen-89482
11/03/2023, 2:28 PMbroad-processor-92400
11/03/2023, 8:53 PMbroad-processor-92400
11/03/2023, 8:59 PMcurved-television-6568
11/03/2023, 9:41 PMbroad-processor-92400
11/04/2023, 10:09 PM2.18.x : important bug fixes only.
Feel free to ask/double check before making a decision!