https://pantsbuild.org/ logo
Join Slack
Powered by
Relatedly. Are we ready to pull the plug on PyPI? ...
# development
b
Relatedly. Are we ready to pull the plug on PyPI? Maybe for 2.19? Maybe even 2.18?
h
Probably 2.19, because I think we need to change the metadata in 2.18 so that this page explains the new distribution model. We need the last thing people see on that page to be reassurance that the project is not defunct, just no longer using pypi for distribution.
(The text there comes from setup.py keywords)
b
I think you can edit the page by hand, no?
Although, there's no reason to pull the plug other than convenience for us
h
No, you can't
AFAICT
It reads it from the wheel metadata
which wheel, I don't know
ours all have the same metadata
b
Wouldn't we just need one publish of 2.18.x with the new metadata then?
And FWIW you're right, here's what I see from one of my PyPI projects:
Project description and sidebar
To set the 'botocore-a-la-carte-route53domains' description, author, links, classifiers, and other details for your next release, use the `setup()` arguments in your `setup.py` file. Updating these fields will not change the metadata for past releases. Additionally, you must use Twine to upload your files in order to get full support for these fields. See the Python Packaging User Guide for more help.
OK Killing it on `main`: https://github.com/pantsbuild/pants/pull/19714 We can decide to cherry-pick later if we wanna bump the schedule
We really should've edited the release notes before we published 2.17.0 šŸ˜ž
h
We can do it in a 2.17.1, it just has to be a stable release
b
Yeah I think, if all else fails, that's the plan
The changelogging of 2.17.1 will be... painful šŸ˜• Since 
start_release
on 
main
won't work as expected
h
Well, we have to have some way to release on earlier branches going forward, at least for a while
If we can't then we have broken things
b
We do. It just means running 
start_release
for 2.17.x on that branch. Since 2.18 and onward use GitHub-changelogs it can be run from 
main
I suppose we could special-case 2.17.x in that script for now.
OK, here's what I think we should do: ā€¢ kill PyPI for 2.18.x. Since we've already killed the changelogging and we already expect people to be using the new github releases ā€¢ Edit 
2.17.x.md
to include the distirbution model switch at the top ā€¢ edit 
start_release.py
on 
main
to fail-fast on 2.17.x. This isn't strictly necessary, but is helpful if anyone gets confused ā€¢ ensure 2.18.x docs (and 
main
) have the correct process documented
h
Fine with me, but we will need to publish 2.17.1 to get the new info onto pypi
it's not a blocker though
if there's a short period where pypi doesn't have the info, that's fine
b
We may want a 
2.17.1
or 
2.17.0.post1
for https://pantsbuild.slack.com/archives/C046T6T9U/p1693421963262249 šŸ˜•
h
Definitely 2.17.1, introducing new naming conventions on the fly seems like a minefield
But also, it's just a WARN, right?
b
Unless you crank those to errors, yes. It's admittedly a very embarrassing one though
(OK so all of those 4 points above are complete)
2 Views
Open in Slack
PreviousNext
Powered by