I m doing a big batch of cherry picking of bug fixes that la Pants #development

I'm doing a big batch of cherry picking of bug fix...

broad-processor-92400

08/29/2023, 10:11 PM

I'm doing a big batch of cherry picking of bug fixes that landed on

main

between 2.18.0a0 and now, since 2.18.x branch was only created recently and so some of them were, e.g. cherry picked to 2.17.x but 2.18.x didn't exist at the time. Sorry for the noise!

bitter-ability-32190

08/29/2023, 10:43 PM

How do I know if I missed the cut on my PRs

broad-processor-92400

08/29/2023, 10:44 PM

I looked over https://github.com/pantsbuild/pants/compare/2.18.x...main I've cherry picked a bunch of yours too

broad-processor-92400

08/29/2023, 10:45 PM

See https://github.com/pantsbuild/pants/compare/main...2.18.x for what's landed and https://github.com/pantsbuild/pants/milestone/60 for what's pending

bitter-ability-32190

08/29/2023, 10:54 PM

How did this happen? Did the milestone not exist until after the branch?

broad-processor-92400

08/29/2023, 10:57 PM

I think the milestone (and branch) were only created today, from the 2.18.0a0 tag

bitter-ability-32190

08/29/2023, 10:58 PM

Oh, yeah that's a problem in the release process then

bitter-ability-32190

08/29/2023, 10:58 PM

FYI @witty-crayon-22786 @happy-kitchen-89482 we may want to tweak that

witty-crayon-22786

08/29/2023, 11:12 PM

I started that release, but didn't finish it, because you were taking it over: sorry about that. I noticed today that neither the branch nor the milestone had been created

bitter-ability-32190

08/29/2023, 11:16 PM

Oh sorry, I meant I was gonna fix the broken release. Anywho, now we know and all I see is an opportunity for more automation 😈

broad-processor-92400

08/29/2023, 11:31 PM

(Looks https://github.com/pantsbuild/pants/pull/19632 was the only one of the dozens of PRs I cherry picked that didn't cherry pick cleanly. Could you take a look @bitter-ability-32190?)

bitter-ability-32190

08/30/2023, 1:08 AM

Probably a timing issue?

bitter-ability-32190

08/30/2023, 1:17 AM

Manually picked: https://github.com/pantsbuild/pants/pull/19703

bitter-ability-32190

08/30/2023, 4:28 PM

Oh: https://github.com/pantsbuild/pants/actions/runs/6027517064/job/16352890479#step:3:35 So GitHub workflows, by default, won't push to a branch if the change contains a workflow yaml. Huh

bitter-ability-32190

08/30/2023, 4:31 PM

I think the solution is to have the