I've created a PR to fix dependency inference for ...
# development
l
I've created a PR to fix dependency inference for Scala 3 enum types. https://github.com/pantsbuild/pants/pull/19588/ Would somebody like to take a look?
🙏 1
f
I've tagged some reviewers onto the PR (including me).
❤️ 1
l
Hey @fast-nail-55400, thanks for taking a look at that code!
I'm at a bit of a loss here, I just don't know what those flags (sawClass, sawTrait, sawObject) are for!
It seems to me like the only one that's actually being used is
sawObject
.
So I've removed the other two.
f
They track whether the identifier was defined via
class
,
trait
, or
object
.
l
Yup, I figured as much, but that information doesn't seem to actually be used for anything, except for objects
@fast-nail-55400, do you have any idea why CI is failing? https://github.com/pantsbuild/pants/pull/19588/checks
f
just the usual Pants CI failures due to build timeouts
I restarted the job
l
Thanks!
Thanks for merging!