Looks like <https://github.com/pantsbuild/pants/pu...
# developmentb
bitter-ability-32190
06/05/2023, 1:51 AMLooks like https://github.com/pantsbuild/pants/pull/19110 never got picked to 2.16.x due to flaky CI. I jsut re-ran
b
broad-processor-92400
06/05/2023, 1:55 AMHuh. Maybe the cherry-pick PRs could be tagged with the milestone, so they're more obvious in https://github.com/pantsbuild/pants/milestone/57 and other similar views?
b
bitter-ability-32190
06/05/2023, 1:56 AMYeah, we could remove the original milestone as well, so there aren't duplicates?
Separately I know @happy-kitchen-89482 wants to propose clean cherry-picks bypass PR altogether...
h
happy-kitchen-89482
06/05/2023, 2:12 AMWell, not necessarily bypass PR, we still need CI, just bypass human code review
b
bitter-ability-32190
06/05/2023, 2:14 AM"CI" is overused. We'd be bypassing PR, and therefore PR checks.
Of course, we wouldn't bypass "CI" in the context of "integration" (we are talking about cherry-picking after all), or in the context of building the release branch.
h
happy-kitchen-89482
06/05/2023, 2:41 AMCI is pretty well-defined in context. It's defined by test.yaml and friends, and includes running all our tests on the various platforms. Which we want to do before merging. And PRs are how we do that. What I propose is that we don't need a human to rubber-stamp a cherry-pick that picked clean and passed CI.
happy-kitchen-89482
06/05/2023, 2:42 AMAnd the PR serves as a record of the cherry-pick
b
broad-processor-92400
06/05/2023, 2:59 AMYeah, we could remove the original milestone as well, so there aren't duplicates?Do you mean removing it from the original issue and/or PRs? I think once a cherry-pickable PR has merged, both of those will be closed, and thus disappear from the (default) milestone view automatically, and the cherrypicked PR is the only record that there's pending work. (strongly agree that cherrypicks should run CI pre-merge: https://graydon2.dreamwidth.org/1597.html)
b
bitter-ability-32190
06/05/2023, 10:55 AM(Good point on the milestone.)
bitter-ability-32190
06/05/2023, 2:42 PMOh so you're saying still make PR, but the PR doesn't run our tests. Ahh
h
happy-kitchen-89482
06/05/2023, 4:30 PMI'm saying make the PR, the PR does run our tests, but gets auto-merged when the tests pass (assuming the pick was clean)
b
bitter-ability-32190
06/05/2023, 4:33 PMAhh I see. Yeah I don't think that's possible to enforce from GitHub's side 😅 The required approvers is for every PR against the branch
w
witty-crayon-22786
06/05/2023, 6:25 PMi’m traveling this week, so if anyone else is able to run the release candidate / release, that would be appreciated. otherwise i can do it next week.
h
happy-kitchen-89482
06/05/2023, 6:53 PMI can do it
w
witty-crayon-22786
06/05/2023, 6:55 PMthank you: the process for 2.16.x hasn't changed: only for 2.17.x/main.
h
happy-kitchen-89482
06/05/2023, 7:18 PMWe're talking about 2.16.0 right?
happy-kitchen-89482
06/05/2023, 7:18 PMDo we need another RC there?
b
bitter-ability-32190
06/05/2023, 7:19 PMMy cherry just landed, which means the next release I can test out on CI at $work.
bitter-ability-32190
06/05/2023, 7:24 PMWhether that's an RC or a real release, that's up for debate I guess?
If we're ok waiting, I'd love to test out 2.16 at $CI
h
happy-kitchen-89482
06/05/2023, 7:29 PMWe always need an RC that is the same as the real release
happy-kitchen-89482
06/05/2023, 7:29 PMso I'll do an RC
b
broad-processor-92400
06/05/2023, 11:46 PM(https://github.com/pantsbuild/pants/pull/19254 for adding the milestones to cherry picks)