Anyone know why Python string import inference rej...
# developmentb
bitter-ability-32190
04/28/2023, 4:22 PMAnyone know why Python string import inference rejects middle dirs that are capitalized? E.g.
a.B.c✅ 1
f
fast-nail-55400
04/28/2023, 4:27 PMbecause it doesn't match the applicable regex: https://github.com/pantsbuild/pants/blob/2ef167b9814853ada9595e9d4a0f35070823d7c1/[…]thon/dependency_inference/scripts/general_dependency_visitor.py
fast-nail-55400
04/28/2023, 4:27 PM Copy code
>>> x = re.compile(r"^([a-z_][a-z_\d]*\.){2,}[a-zA-Z_]\w*$", re.UNICODE)
>>> x.match("a.b.c")
<re.Match object; span=(0, 5), match='a.b.c'>
>>> x.match("a.B.c")
>>>b
bitter-ability-32190
04/28/2023, 4:27 PMRight, but why did we make that regex so? Is it on purpose?
bitter-ability-32190
04/28/2023, 4:27 PMI'm porting the behavior so I wanna make sure I'm not missing something obvious
f
fast-nail-55400
04/28/2023, 4:28 PMthat I do not know
b
bitter-ability-32190
04/28/2023, 4:28 PMgit blamebitter-ability-32190
04/28/2023, 4:32 PMSeems like no reason, specifically: https://github.com/pantsbuild/pants/commit/5e4f123a1dbc47313fe91cb4856aafae1d678887
c
curved-television-6568
04/28/2023, 6:33 PMif
import a.B.cb
bitter-ability-32190
04/28/2023, 6:58 PMYeah I can't see why not. Bugs going to be fixed soon
👍 1
h
happy-kitchen-89482
04/28/2023, 9:11 PMThe whole thing is a heuristic, and that capitalization is very non-standard (although, of course, allowed), so it seemed like the odds of it being a false positive were higher than it being a false negative.
happy-kitchen-89482
04/28/2023, 9:11 PMSo it's not a "bug" per se, just an attempt to keep the heuristic contained.
happy-kitchen-89482
04/28/2023, 9:11 PMMaybe the alternative is better, maybe not
b
bitter-ability-32190
04/28/2023, 9:22 PMThe new world will be very permissive, as if we're wrong we just silently ignore the string
bitter-ability-32190
04/28/2023, 9:26 PMAssets are much more false-positive likely, but still. Likelihood should be low since string == target