I ve got a rule graph question about u

Question

< witty crayon 22786> I ve got a rule graph question about unions and in scope params thread

curved-television-6568 · Answer

I see that when a rule has a `Get` for a union that ends up as a re entry query node in the graph due to the presence of `in scope params` it has

curved-television-6568 · Answer

Now I wonder was union any special before the environments feature since to me it would seem that this is the one thing that disconnects the graph at the rule asking for a type with a union ~member~ type as param

curved-television-6568 · Answer

Or rather I m wondering if this disconnect was done to satisfy some requirement coming from the environments feature Iiuc before it would just be a fan out of many dependencies one for each member type of the union for the requested product right

witty-crayon-22786 · Answer

<https github com pantsbuild pants issues 12934> had been open for a while with the goal of having a more explicit API for plugin developers

witty-crayon-22786 · Answer

at various points though i needed to revisit that issue for performance reasons because simplifying the solving of unions and bounding what was in scope made graph solving much cheaper

curved-television-6568 · Answer

Thanks And with that I assume I got most of the above correctly and the driving force here seems to be performance related right

curved-television-6568 · Answer

meaning I don t see a particular reason for not having all the params in scope all the way

curved-television-6568 · Answer

besides perf

witty-crayon-22786 · Answer

gt with the goal of having a more explicit API for plugin developers

witty-crayon-22786 · Answer

basically if all params are in scope a plugin author can t actually know what is available to them when authoring a plugin and maintainers can accidentally provide things that shouldn t be part of the API

curved-television-6568 · Answer

oh so you should have to be more explicit with what types you need

witty-crayon-22786 · Answer

right it s essentially defining the signature API for a plugin

curved-television-6568 · Answer

by plugin do you refer to the set of rules registered by that plugin

witty-crayon-22786 · Answer

yes

curved-television-6568 · Answer

so isn t that on another level as this all is on the rule level

witty-crayon-22786 · Answer

not sure what you mean

curved-television-6568 · Answer

there s no concept of plugins or set of rules now just a big graph of all the rules so plugins then would perhaps be the operation of joining merging adding rule graphs together and here I can see plugins being used as a compatibility filter on which graphs may be joined

curved-television-6568 · Answer

but the notion of plugins as I see it wouldn t manifest in the tasks them selves

witty-crayon-22786 · Answer

hm i suppose but i m not sure that the distinction is meaningful

witty-crayon-22786 · Answer

as it stands a plugin can essentially only provide itself via ` unions` any ` rules` that hook into the graph in any other way aren t really a plugin

witty-crayon-22786 · Answer

because the graph will fail to compile without them

curved-television-6568 · Answer

ah ok that s slightly different from what I imagined

curved-television-6568 · Answer

so plugin gt rule graph hooks

curved-television-6568 · Answer

nvm the last I m just pondering thanks for the inputs

witty-crayon-22786 · Answer

sure thing