Could a github admin please delete my cherry-pick branches? I will push to my fork for future cherry picks. Sorry: https://github.com/pantsbuild/pants/branches • cherry-pick-18610-to-2.16.x • cherry-pick-18619-to-2.16.x

That does not appear to be trivially possible:

$ git push upstream :cherry-pick-18610-to-2.16.x
remote: error: GH006: Protected branch update failed for refs/heads/cherry-pick-18610-to-2.16.x.
remote: error: Cannot delete this branch
To <https://github.com/pantsbuild/pants>
 ! [remote rejected]       cherry-pick-18610-to-2.16.x (protected branch hook declined)
error: failed to push some refs to '<https://github.com/pantsbuild/pants>'

I'll temporarily disable branch protection / do it / re-enable.

sorry 😞 Thank you

Should those branches even be configured as protected?

I'm guessing it's a glob

*.x

or similar.

Yeah.

yeah I'm thinking maybe the branch protection rule if it is regex should be rooted with

^

and

$

I'm reading up on syntax to see if I can do better 1st. Appears to only accept simple globs not regex.

Then the thing to do might be 2 globs:

1.*.x

and

2.*.x

Reading is the right thing to do. They use this: https://ruby-doc.org/core-2.5.1/File.html#method-c-fnmatch I'll fix it.

ah ruby

Done and done. @proud-dentist-22844 did you use Josh's script for this or hand-roll the PR?

I used the script which delegates to

gh

to push the branch. When prompted, I selected pushing to pantsbuild/pants instead of my fork. That said, changing the branch name it creates could resolve this. Though I did have to make one modification to the script for it to succeed: looks like github api is prefixing

app/

on author login names for some weird reason.

Ok. Well, that's an option then. I'll leave it to script users to fix up. I don't like exactly this sort of automation.