https://pantsbuild.org/ logo
Powered by
e

enough-analyst-54434

03/31/2023, 4:23 PM
I have release duty today. It looks like the following are on the docket in addition to the 2.17 dev release: + 2.14.2 final 2.14.2rc1 + 2.15.1rc1 + 2.16.0rc0
@witty-crayon-22786 I know you have a busy day mixed in with a fix that's probably bound for >=2.15.x and I can adjust my schedule to pick up that fix if the fix seems feasible ~today. Others - let me know what you have brewing if anything.
w

witty-crayon-22786

03/31/2023, 4:26 PM
I can adjust my schedule to pick up that fix if the fix seems feasible ~today
thank you… i’m hoping to get a quick fix out this morning for cherry-pick.
n

narrow-vegetable-37489

03/31/2023, 4:33 PM
Would be great to have this cherry-pick merged to 2.15.x: https://github.com/pantsbuild/pants/pull/18377
e

enough-analyst-54434

03/31/2023, 4:35 PM
Ah, looks like an oversight - done.
🙏 1
b

bitter-ability-32190

03/31/2023, 4:36 PM
I'll try and cherry pick my 2.14.x PR. @happy-kitchen-89482 or @enough-analyst-54434 can y'all approve? I don't have it handy I'm on mobile but it's on the 2.14 milestone
e

enough-analyst-54434

03/31/2023, 4:37 PM
Taking a look Josh...
@narrow-vegetable-37489 is that cherry pick also in 2.16?
The 2.14 milestone appears to be nuked!
n

narrow-vegetable-37489

03/31/2023, 4:39 PM
The original MR was merged to main before 2.16 was branched off afaik.
e

enough-analyst-54434

03/31/2023, 4:39 PM
Ok, great - thanks @narrow-vegetable-37489
w

witty-crayon-22786

03/31/2023, 4:39 PM
The 2.14 milestone appears to be nuked!
just “closed” probably: can reopen
e

enough-analyst-54434

03/31/2023, 4:43 PM
Ok, thanks. Re-opened. It doesn't seem to make sense to close a milestone for a branch in rc state ever.
w

witty-crayon-22786

03/31/2023, 4:44 PM
yea. it went back into rc state recently
b

bitter-ability-32190

03/31/2023, 5:48 PM
I didn't get a chance to cherry pick anything before road trip time, so if someone else is able to do that that'd be awesome.
w

witty-crayon-22786

03/31/2023, 5:51 PM
i’m tied up for the next three hours, but here is an attempted fix for the process shutdown race: https://github.com/pantsbuild/pants/pull/18632
👀 1
e

enough-analyst-54434

03/31/2023, 6:14 PM
Alright, I'll man-handle both Josh's #18622 and Stu's #18632 to get them in main and then cherry-picked back through 2.14.x each.
h

happy-kitchen-89482

03/31/2023, 6:20 PM
@enough-analyst-54434 I can handle #18622 (will give me something to do on this flight to Austin), if you do the Rust one?
e

enough-analyst-54434

03/31/2023, 6:21 PM
Sure, sounds great. Thanks @happy-kitchen-89482.
b

bitter-ability-32190

03/31/2023, 6:31 PM
Many thanks
h

happy-kitchen-89482

03/31/2023, 7:42 PM
e

enough-analyst-54434

03/31/2023, 8:21 PM
@happy-kitchen-89482 you appear to still be punching through stuff on main. I'll hold off on 2.17.0.devX and proceed with the other branch releases. I think everything is in on 2.14.x, 2.15.x and 2.16.x.... save for Stu's fix which I'll be cherry-picking 1st to those branches.
h

happy-kitchen-89482

03/31/2023, 9:24 PM
I haven't merged some of the above yet
Waiting for CI
The cherry picks that is
I have one 2.17.0.dev2 deprecation pending (the default ICs) but feel free to punt that to dev3 if you want to move ahead with the dev release
Ah you merged them while I was landing.
So feel free to not wait for my deprecation removal, it will require punching up a whole lot of tests
w

witty-crayon-22786

03/31/2023, 10:39 PM
back: thanks John, Benjy
e

enough-analyst-54434

04/01/2023, 12:35 AM
Ok, the 2.17.0.dev2 prep (https://github.com/pantsbuild/pants/pull/18643) is merged; so main is freed up. @happy-kitchen-89482 I took you up on your no-wait offer and bumped the deprecations.
👍 1
Alright - thanks everyone for your help with these releases. They're all complete. The only issue I encountered was in syncing the 2.17.0.dev2 docs:
Copy code
jsirois@Gill-Windows:~/dev/pantsbuild/jsirois-pants (main) $ git log -1
commit 5ec0d9b0d626e3b9643d2b64d730ede2aacc1872 (HEAD -> main, tag: release_2.17.0.dev2)
Author: John Sirois <john.sirois@gmail.com>
Date:   Fri Mar 31 17:34:20 2023 -0700

    Prepare the 2.17.0.dev2 release. (#18643)
jsirois@Gill-Windows:~/dev/pantsbuild/jsirois-pants (main) $ npx rdme docs docs/markdown --version v2.17
🔑 <mailto:jsirois@toolchain.com|jsirois@toolchain.com> is currently logged in, using the stored API key for this project: pants

Error uploading docs/markdown/Ad-Hoc Tools/adhoc-tool.md:

We couldn't save this doc (Path `category` is required.).

<https://docs.readme.com/main/reference> and include the following link to your API log: '<https://docs.readme.com/main/logs/30ebca29-cd34-4b33-a75b-77f2a3906621>'.
@ancient-vegetable-10556 / @happy-kitchen-89482 I'm just noting this here so it's not lost. I can't make sense of this error at the moment.
Ok, I messed around with this a good bit and still cannot get the doc sync working. The required 
category
nets a readme help hit which leads to:
Copy code
jsirois@Gill-Windows:~/dev/pantsbuild/jsirois-pants (adhoc-tool/doc-sync-fix *) $ git diff
diff --git a/docs/markdown/Ad-Hoc Tools/adhoc-tool.md b/docs/markdown/Ad-Hoc Tools/adhoc-tool.md
index 4a6b8b8965..c7d4de403c 100644
--- a/docs/markdown/Ad-Hoc Tools/adhoc-tool.md
+++ b/docs/markdown/Ad-Hoc Tools/adhoc-tool.md
@@ -1,5 +1,6 @@
 ---
 title: "Integrating new tools without plugins"
+category: 635cb520ef2b4800560c297d
 slug: "adhoc-tool"
 hidden: false
 createdAt: "2023-03-20T00:00:00.000Z"
jsirois@Gill-Windows:~/dev/pantsbuild/jsirois-pants (adhoc-tool/doc-sync-fix *) $ npx rdme docs docs/markdown --version v2.17
🔑 <mailto:jsirois@toolchain.com|jsirois@toolchain.com> is currently logged in, using the stored API key for this project: pants

Error uploading docs/markdown/Ad-Hoc Tools/adhoc-tool.md:

We couldn't save this doc (Unable to find a category with the id '635cb520ef2b4800560c297d'. Is the version correct?).

<https://docs.readme.com/main/reference> and include the following link to your API log: '<https://docs.readme.com/main/logs/4bd8c032-7107-406f-83bf-40b5144a4348>'.
I got that category id from their API - it's our "Using Pants" category:
Copy code
{
  "title": "Using Pants",
  "slug": "using-pants",
  "order": 3,
  "reference": false,
  "_id": "635cb520ef2b4800560c297d",
  "project": "5e508f9389a7e90045b2f7e8",
  "version": "635cb520ef2b4800560c2ac1",
  "isAPI": false,
  "createdAt": "2020-02-22T02:44:36.066Z",
  "__v": 0,
  "type": "guide",
  "id": "635cb520ef2b4800560c297d"
}
So, I'm out of ideas here and will drop this.
h

happy-kitchen-89482

04/01/2023, 4:23 PM
Things rings a bell, but not loudly enough that I know the solution offhand. I will poke at it today.
As soon as I get to good wifi, that is. The wifi at PyTexas is oddly very poor.
Fixed. The issue was that there needs to be a stub page created via the readme UI before you can sync to it. Their sync client won't create new pages.
There was such a page in 2.16, but not in 2.17
And this is an example of why I don't like that we cut a new docs version during development rather than when we start stabilizing the branch
Stabilization is often when we create new docs pages, which requires annoying manual intervention, and having a dev docs branch means we have to do this twice.
The other reason being that readme has no 
dev
status, so we end up with this:
Screenshot 2023-04-01 at 4.08.01 PM.png
Which is inaccurate, and also confusing to the user
w

witty-crayon-22786

04/03/2023, 4:12 PM
yea, i think that it would be fine to make that edit to the release process, if you’d like to. we used to eagerly cut the site so that you could make edits to it… but now the edits can still be made on 
main
, before they can necessarily be published, and that’s fine
Powered by