https://pantsbuild.org/ logo
#development
Title
# development
w

witty-crayon-22786

03/13/2023, 5:42 PM
@wide-midnight-78598: what help do you need with review for https://github.com/pantsbuild/pants/pull/18326 ?
w

wide-midnight-78598

03/13/2023, 5:53 PM
None yet, I wasn't around the past few weeks - so I haven't looked at it much at all. More of a higher-level idea that all targets should be "approved" or "agreed upon" in some fashion, to maintain some level of consistency and abstractness
w

witty-crayon-22786

03/14/2023, 5:48 PM
it looks good to me: i’ll probably merge this time tomorrow unless you have any other thoughts on it
w

wide-midnight-78598

03/14/2023, 9:07 PM
I'm pretty KO'd with some sort of illness, I'll try to look at it a bit tonight. But yeah - if it passes tests, and the API looks okay, then great! My test would be on a couple repos
w

witty-crayon-22786

03/14/2023, 9:08 PM
that would still be worth doing post merge too.
thanks! hope you feel better.
w

wide-midnight-78598

03/14/2023, 9:14 PM
Yeah for sure, would be done regardless - was just hoping to get a chance to do it before merge, in case anything easy popped out. But who knows
@witty-crayon-22786 No need to wait on me for any merging, my use case is exclusively Typescript-based - so there are going to be some small tweaks/config changes I'll need to do for my repos regardless.