<#12946 Rules API: allow using a `Get` with no arg...
# github-notifications
q
#12946 Rules API: allow using a `Get` with no arguments Issue created by Eric-Arellano This rule is slow because it finds binaries that aren't actually needed. Even if you are unzipping a
.zip
file, we'll still find Tar: pants/src/python/pants/core/util_rules/archive.py Lines 168 to 206 in </pantsbuild/pants/commit/636a5c7bcd609d1a4a44770a777ceb10e0a794fb|636a5c7> Because
UnzipBinary
is a singleton, there is nothing we can pass for the input of the
Get
. So we either have to put the type in the
@rule
signature or add a new type like
UnzipBinaryRequest
, so you could do
await Get(UnzipBinary, UnzipBinaryRequest)
. Instead, I propose we allow
await Get(UnzipBinary)
. pantsbuild/pants
u