<#17342 Simplify our APIs to leverage `Get()` with...
# github-notifications
q
#17342 Simplify our APIs to leverage `Get()` with no arguments New issue created by Eric-Arellano We have some types like
AllTargetsRequest
and
ZipBinaryRequest
that solely existed to work around the lack of #12946. That is, it allowed us to "lazily" evaluate things, e.g. inside if statements, by doing
await Get(ZipBinary, ZipBinaryRequest)
. Now that we can do
Get(ZipBinary, {})
, we should deprecate and then delete those old APIs. We only need the "singleton" rules that return
ZipBinary
without needing to have a
ZipBinaryRequest
. This change will make for less code and a tighter rule graph.
we should deprecate
We can do that by putting
warn_or_error()
inside the rules for
ZipBinaryRequest
et al. pantsbuild/pants