thinking about creating a new plugin that requires...
# pluginsr
rapid-bird-79300
09/09/2021, 9:24 PMthinking about creating a new plugin that requires to know source files git information. For example, we would need to know if a source file has been added, removed, modified. Is there a way to get this info in pants now?
I guess another option is to create a custom rule to run gitpython. Maybe something like this?
Copy code
source_files_git_info = await Get(
SourceFilesGitInfo,
SourceFilesGitInfoRequest(source_files),
)👍 1
w
witty-crayon-22786
09/09/2021, 10:25 PMit would be possible, yea… most likely the rule would need to be marked
@_uncacheablewitty-crayon-22786
09/09/2021, 10:26 PMbut note that Pants already internally interacts with Git, and so it might amount to refactoring existing APIs to expose them from
@rules➕ 1
witty-crayon-22786
09/09/2021, 10:28 PMhm, yea. a relevant function is: https://github.com/pantsbuild/pants/blob/433a4dd9944feedd4aa8d4b17ffeba927e35a69b/src/python/pants/init/specs_calculator.py#L25-L31 … but as an artifact of history, it is not an
@rulewitty-crayon-22786
09/09/2021, 11:09 PMbut yea, exposing source control is definitely something that some built in
@rules➕ 2
h
hundreds-father-404
09/11/2021, 7:01 PMAgreed, that would be awesome to have for plugin authors. Happy to help too
r
rapid-bird-79300
09/13/2021, 5:28 PMyeah I agree that would be a great feature to have for writing plugins. I have limited bandwidth at the moment but I would be interested to learn how we can achieve this
4 Views