this is a separate fix in a different file (`daemo...
# announce
a
this is a separate fix in a different file (
daemon_pants_runner.py
) where we fail to properly encode the exit code into a nailgun exit chunk, which you then fixed in
1702d98489ff44ddcb4ccdc1e470e84356051455
by adding
from builtins import str
, which was exactly the fix i had. i'm thinking a fix involves moving all the text/binary conversions into
nailgun_protocol.py
so we don't have to think about it each time -- i have confirmed that an internal ci run which runs the pants version in upstream master does not repro the nailgun error (and i was able to repro it 100% of the time before). i could bisect to be sure, but i independently found the encoding error and fixed it exactly the same way, and that i was able to confirm specifically fixed it (and i also confirmed that the exit chunk we were sending was different so i know it's actually the right fix).
👍 1