https://pantsbuild.org/ logo
#announce
Title
# announce
h

hundreds-father-404

11/11/2020, 11:07 PM
Hm, I accidentally bumped the VERSION for 2.0.x before merging a cherry-pick. The changelog is still accurate. Any preference on how I proceed? I can release off of the merge of the cherry-pick, even though it’s after the version bump. The git tag will be on that cherry-pick merge
f

fast-nail-55400

11/11/2020, 11:08 PM
is this for patchlevel?
h

hundreds-father-404

11/11/2020, 11:08 PM
yeah, this is for 2.0.1rc0
f

fast-nail-55400

11/11/2020, 11:09 PM
is that what you bumped to?
h

hundreds-father-404

11/11/2020, 11:09 PM
yes
so, we’ll land one commit after that version bump, and then do the release from there
f

fast-nail-55400

11/11/2020, 11:09 PM
maybe just release next as 2.0.1rc1?
and “forget” 2.0.1rc0
and just document that it was skipped
you’ll find many examples of projects that have had “spurious” releases
I guess it’d be fine with the cherry-pick after the version bump but where will any tag be?
but future people reading the commit log would assume that the cherry-pick was in 2.0.1rc1 and not 2.0.1rc0
h

hundreds-father-404

11/11/2020, 11:11 PM
That technically means having to do another release prep on the
master
branch, then cherry-picking into 2.0.x etc, which is slow ik it’s not kosher, but is there a particular issue with releasing from one commit after the VERSION bump? The end-user .rst changelog is still accurate
f

fast-nail-55400

11/11/2020, 11:12 PM
accuracy of the commit log
h

hundreds-father-404

11/11/2020, 11:12 PM
git tag would be on the commit right after the VERSION bump
f

fast-nail-55400

11/11/2020, 11:12 PM
I guess it is fine if the tag is set on the right commit
👍 1
h

hundreds-father-404

11/11/2020, 11:13 PM
cool, I think so too. thanks!