https://pantsbuild.org/ logo
#announce
Title
# announce
w

witty-crayon-22786

03/23/2021, 10:28 PM
time to start the discussion for
2.4.0rc0
!
does anyone have anything that they’d like to get in before we cut?
h

hundreds-father-404

03/23/2021, 10:33 PM
I'd like to get this new error message for dep inference ambiguity. I think I'm pretty close
👍 1
w

witty-crayon-22786

03/24/2021, 9:05 PM
going to go do dinner/bedtime. back a bit later
h

hundreds-father-404

03/25/2021, 12:36 AM
Same, I gotta start prepping for hosting my friend staying with me. I did not get to the Pex issue I'm having 😕 But the warning should now be 100% complete with that followup PR now up!
👍 1
w

witty-crayon-22786

03/25/2021, 4:00 AM
sounds like everything is in for this! i’ll cut tomorrow morning unless someone beats me to it.
h

hundreds-father-404

03/25/2021, 3:31 PM
Not quite, we do need that Pex release. We have at least two broken users @enough-analyst-54434 merged the fix this morning. John, would you be able to please do a Pex release this morning? One of us can happily do it too if you're out. (Either way, I can handle the Pants side of the upgrade!)
e

enough-analyst-54434

03/25/2021, 3:34 PM
Yeah, I'll be working a good chunk today so I'll get all this done. @hundreds-father-404 you had alluded to being willing to test. Since I have no repro in hand I was hoping you'd test out the fix; ie: run tox -epackage, etc. Let me know if you need instructions.
h

hundreds-father-404

03/25/2021, 3:35 PM
Ah, I commented on the Pex PR. I tested a few minutes ago - it fixed it! Tested by changing the venv script in
named_caches
e

enough-analyst-54434

03/25/2021, 3:37 PM
Gotcha. OK. Great. I'd still love to know what the link structure is for this particular brew setup. Any failure - but these seem to just mainly happen for macOS - that does not repro in CI is disturbing to go forward with without fully understanding what's going on.
And I do not fully understand what's going on.
h

hundreds-father-404

03/25/2021, 3:39 PM
Okay, I'm available most the day for any additional testing you'd like
w

witty-crayon-22786

03/25/2021, 3:41 PM
I figured that we could cut without this fix and cherrypick if need be, since it's an rc0: I'll wait till later today though. This fix does block 2.3.1 though. Thanks folks.
merged https://github.com/pantsbuild/pants/pull/11799 : thanks a lot! … will start 2.4.0rc0 prep
❤️ 1
e

enough-analyst-54434

03/25/2021, 6:17 PM
OK. Be careful, I'm actually active here. I'll take the 2.3.x cherry-pick.
👍 1
b

busy-vase-39202

03/26/2021, 1:05 AM
"Enabled use of pytest-html, and other Pytest plugins that write output to files." is in the release notes for 2.4.rc0 https://www.pantsbuild.org/v2.4/docs/release-notes-2-4 but I don't see it cited explicitly in the detailed changelog for 2.4 series. https://github.com/pantsbuild/pants/blob/main/src/python/pants/notes/2.4.x.md Does it need to be added?
b

busy-vase-39202

03/26/2021, 1:20 AM
I suspect not a lot of web devs are gonna recognize that means pytest-html is supported. As a sample of one, I didn't. Might be worth adding a couple words there to make explicit how Pants is becoming more useful for web developers.
w

witty-crayon-22786

03/26/2021, 1:38 AM
pytest-html is a way of rendering test reports, rather than an integration with frontend development
👍 2
i’ll add a link in the overview