@witty-crayon-22786 cleaned up non-porting related comments in my PR. Fixed the broken tests, switched to enum. Mind taking another look? https://github.com/pantsbuild/pants/pull/4227