Also, why do we box all of our futures?

Because

impl Trait

isn't stable yet (https://github.com/rust-lang/rust/issues/34511), meaning that a function must return something of a known size... we box to put them on the heap when the type isn't known in advance.

ok, cool 🙂 BoxedFuture has been deprecated upstream, with the suggested replacement that you manually Box::new all the things. I guess I can put together that replacement, but I'll land it after re-formatting, because I imagine a formatter would make that a nicer thing to land

The BoxFuture deprecation is a funny one, because it's not actually deprecated last I checked, and

impl Trait

is on the way to remove the constraint? I think we have a ticket about it, but.