On `inotify`: Any time we stop the thread, we need...
# developmenta
average-vr-56795
02/26/2018, 9:50 AMOn `inotify`: Any time we stop the thread, we need to re-crawl everything we were watching, because we may have missed notifications while the thread was stopped. This is slow, blocking, and generally sad.
w
witty-crayon-22786
02/26/2018, 4:43 PMso regarding shutting down... i'm on the fence as to whether we want the forked runner to use inotify. i don't think there is harm in it, but also doesn't seem strictly necessary
witty-crayon-22786
02/26/2018, 4:44 PMoh. but you're suggesting that the parent process would need to do that as well...?
witty-crayon-22786
02/26/2018, 4:44 PMyea.
witty-crayon-22786
02/26/2018, 4:44 PMok, i'll post it at the very least.
witty-crayon-22786
02/26/2018, 4:45 PMa
average-vr-56795
02/26/2018, 4:46 PMYeah, the parent process needs inotify and needs it not to be interrupted. The child process can go either way.
3 Views