I kind of want `Get`s to use named args because I m never go Pants #development

I kind of want `Get`s to use named args, because I...

average-vr-56795

04/13/2018, 5:55 AM

I kind of want `Get`s to use named args, because I’m never going to remember what order things go in

aloof-angle-91616

04/13/2018, 8:47 PM

there's the "informal" version

Get(<ProductType>, <SubjectType>(<subject value>))

which seems neat

aloof-angle-91616

04/13/2018, 8:48 PM

i tend to read

Get(<P>, <S>, <value>)

as "given this value, interpret it as an S, and execute the rule to convert it to a P" right to left

aloof-angle-91616

04/13/2018, 8:48 PM

where would you see names being used?

aloof-angle-91616

04/13/2018, 8:48 PM

(I like named arguments a lot in general)

aloof-angle-91616

04/13/2018, 8:49 PM

i can see

Get(to=ProductType, from=SubjectType, subject=my_value)

being neat

average-vr-56795

04/16/2018, 9:24 AM

Yeah, exactly like that, with `to`/`from`/`subject` or something 🙂 Literally everywhere that

Get

is called

aloof-angle-91616

04/16/2018, 4:21 PM

i would actually be totally down for that i just need to drop into rules.py again to see where to change

average-vr-56795

04/16/2018, 4:23 PM

Woo 🙂

average-vr-56795

04/16/2018, 4:23 PM

(I still long for a language feature of “require this arg to be a named arg”)

aloof-angle-91616

04/16/2018, 4:24 PM

i feel like if we're parsing the rule body anyway we could check while processing that AST that the Get() invocation has named args

average-vr-56795

04/16/2018, 4:25 PM

We could I guess… Hmm… I’m not sure how I feel about that…

2 Views