and so i was trying to do a product_request() from...
# developmenta
aloof-angle-91616
04/25/2018, 4:21 PMand so i was trying to do a product_request() from within the BuildLocalPythonDistributions task
w
witty-crayon-22786
04/25/2018, 5:45 PMthis really isn't intended to be supported right now
witty-crayon-22786
04/25/2018, 5:46 PMi think that maybe it can be made to work, but there isn't an official way to plug in additional
@rulesregister.pywitty-crayon-22786
04/25/2018, 5:46 PMotherwise the startup code ends up with a dependency on the c++ backend, or whatever
a
aloof-angle-91616
04/25/2018, 5:46 PMoh oops i added that with ~3 lines of code in engine_initializer.py
aloof-angle-91616
04/25/2018, 5:46 PMit's not a hack and i almost guarantee you will think it is a good idea
w
witty-crayon-22786
04/25/2018, 5:46 PMwould be good to land that as a separate PR then.
a
aloof-angle-91616
04/25/2018, 5:46 PMgot it
w
witty-crayon-22786
04/25/2018, 5:55 PMif the PR isn't big, then it's not big. but adding a way to extend the engine is an important step, and looking at it in isolation would be good.
witty-crayon-22786
04/25/2018, 5:55 PM(i should have created an independent ticket for it maybe... but it's one of those things that was going to happen this way all along... you add it when you need it.)
a
aloof-angle-91616
04/25/2018, 5:58 PMyeah i'm gonna break that out into a separate PR, it's extremely small
3 Views