So… Variants… Do they work today? If so, how? What...
# developmenta
average-vr-56795
05/09/2018, 12:22 PMSo… Variants… Do they work today? If so, how? What exactly do they do?
w
witty-crayon-22786
05/09/2018, 4:30 PMthey do not work today. but they're described in the engine readme
witty-crayon-22786
05/09/2018, 7:37 PMthey worked for the purposes of experiments, but while productionizing the rust code they bitrotted because we didn't need them to fill the BuildGraph API
witty-crayon-22786
05/09/2018, 7:38 PMthe issue mentioned in https://github.com/pantsbuild/pants/issues/5788 is a pretty fundamental weakness of how they were implemented, so i think there is some design work needed there to nail that down.
a
average-vr-56795
05/10/2018, 8:57 AMWhen you say the engine readme… It’s not in https://github.com/pantsbuild/pants/blob/master/src/rust/engine/README.md or https://docs.google.com/document/d/1C64MreDeVoZAl3HrqtWUVE-qnj3MyWW0NQ52xejjaWw/edit?usp=sharing which it links to…
average-vr-56795
05/10/2018, 8:58 AMDo you have an opinion on fixing variants vs removing them and writing something from scratch (which may look similar) to solve concrete use-cases?
w
witty-crayon-22786
05/10/2018, 4:38 PMwitty-crayon-22786
05/10/2018, 4:38 PMmore cost to remove than to replace, i think
a
average-vr-56795
05/10/2018, 4:39 PMAha, thanks!
3 Views