<@U6ZRNH0TC>: i'm guessing i'm missing something b...
# developmentw
witty-crayon-22786
05/21/2018, 6:59 PM@aloof-angle-91616: i'm guessing i'm missing something big, but: with regard to https://github.com/pantsbuild/pants/pull/5769/files#r189682029 ... can we just eagerly fail in
VFS::expanda
aloof-angle-91616
05/21/2018, 7:02 PMhm, i think we can, and i think that we could avoid all the changes to native.py if we did that. it would also almost definitely be significantly faster
aloof-angle-91616
05/21/2018, 7:02 PMi don’t see a reason the dict or whatever is needed when you put it like that
aloof-angle-91616
05/21/2018, 7:03 PMi’ll check your comment on the thread but i think i know what to do
aloof-angle-91616
05/21/2018, 7:04 PM@average-vr-56795 also seeing your comments (thanks!!!), will merge the two
w
witty-crayon-22786
05/21/2018, 7:06 PM@aloof-angle-91616: ok. please don't be afraid to ask questions about this stuff... you do a huge amount of good work, but with some more discussion we could save you some time!
a
aloof-angle-91616
05/21/2018, 7:11 PMtrue; i guess i didn’t ask before because i didn’t view that as unnecessary work because i learned a ton more about the native api surface (there was another version of the work not reflected in those commits even). totally agree in general though oops