https://github.com/pantsbuild/pants/pull/5769 is green, i added a few tests to

engine/test_fs.py

as well as you suggested in this channel a week ago, all the todos were made into followup tickets as well