also the conversions were pretty explicit, i can't...
# developmenta
aloof-angle-91616
09/10/2018, 6:24 PMalso the conversions were pretty explicit, i can't think of a more explicit way than saying
convert(tuple)a
average-vr-56795
09/11/2018, 1:04 PMThe call site isn’t explicit though…
average-vr-56795
09/11/2018, 1:04 PMWhen I write:
SomeDatatype('foo')SomeDatatype(('f', 'o', 'o'))a
aloof-angle-91616
09/12/2018, 4:12 AMthat's very scary and very bad!!!!
aloof-angle-91616
09/12/2018, 4:12 AMno joke
aloof-angle-91616
09/12/2018, 4:13 AMthat also reminds me one of the default values for a jvm option is supposed to be a 1-element tuple and isn't let's find that
aloof-angle-91616
09/12/2018, 8:00 AMremembered it and fixed it! https://github.com/pantsbuild/pants/pull/6497
aloof-angle-91616
09/12/2018, 8:14 AMand also thanks for the thorough review on https://github.com/pantsbuild/pants/pull/6374
a
average-vr-56795
09/12/2018, 9:37 AMHurrah! 🙂