https://pantsbuild.org/ logo
#development
Title
# development
s

salmon-summer-38098

10/01/2018, 6:09 PM
@aloof-angle-91616 - let me know when you are ready for me to review your split up changes
a

aloof-angle-91616

10/01/2018, 6:10 PM
6552 should be ready for review! there are TODOs which should be made into issues links or i should link the PRs i made this weekend is the only further change
s

salmon-summer-38098

10/01/2018, 6:10 PM
ok, sounds good - I will review that now then
a

aloof-angle-91616

10/01/2018, 6:10 PM
great
just left the shower and coming in i swear soon i got way too hyped explaining the nailgun thing because i realized it was just in my head is all
s

salmon-summer-38098

10/01/2018, 6:12 PM
take your time
a

aloof-angle-91616

10/01/2018, 6:12 PM
sick
thanks
the other PRs are marked WIP and i won't look at them at all for now but when we sync on next steps they are basically my attempts at moving everything i was trying to do in 6552 that wasn't about logging out of it (which btw obviously greatly improves the change) so if the logging shows we have a problem to fix in pants either with signal handling or pailgun interactions we have something very concrete to work off of
i will mark 6552 not wip anymore
well, i'll make issues for TODOs, then do that