https://pantsbuild.org/ logo
#development
Title
# development
w

witty-crayon-22786

10/31/2018, 3:10 PM
@red-balloon-89377: i had seen
chttp
r

red-balloon-89377

10/31/2018, 3:30 PM
Thanks! That looks great, except it has no option for async requests that I can see. The actual reading and storing of the file can be async, because it returns a stream, but nobody can save us from the network latency. That said, even if we were to make the request async, we do wait for it to complete before returning from the node execution, so we’d probably not be gaining much?
w

witty-crayon-22786

10/31/2018, 3:37 PM
Yea, I think the API in the ticket was currently blocking anyway. This would be a stopgap
@red-balloon-89377: There is a CpuPool that we can/should run this kind of work on to avoid blocking the tokio threads... I forgot to mention that in the review.
Will comment
r

red-balloon-89377

10/31/2018, 3:38 PM
Okay, cool 🙂 thanks.
@witty-crayon-22786 You might want to check out the comment I just left regarding the travis failures
w

witty-crayon-22786

11/01/2018, 4:39 PM
yea, saw that. thanks
r

red-balloon-89377

11/01/2018, 4:43 PM
Would you like me to keep trying to figure out the SSL error with
reqwest
? If we eventually need to switch it would be useful, but I don’t have a good intuition of how much of a stopgap
chttp
is.
w

witty-crayon-22786

11/01/2018, 4:44 PM
i'm going to look into the segfault i think.
@red-balloon-89377: are there any other issues that look interesting for you?
the "improve engine UI" one is relatively small, without dependencies
r

red-balloon-89377

11/01/2018, 4:46 PM
Sounds good 🙂
w

witty-crayon-22786

11/01/2018, 4:46 PM
the "Consume logger/console" one would interact fairly heavily with python code, but is otherwise fairly small
r

red-balloon-89377

11/01/2018, 4:46 PM
I thought that was going to be a bigger one
w

witty-crayon-22786

11/01/2018, 4:47 PM
yea, it would be. i take that back. "medium to large"
r

red-balloon-89377

11/01/2018, 4:47 PM
Assuming I will be ooo for most of next week, I think the improve engine UI is better
w

witty-crayon-22786

11/01/2018, 4:47 PM
ok, yes please!