1 and 2 are necessary... but i think it actually d...
# developmentw
witty-crayon-22786
12/06/2018, 8:28 PM1 and 2 are necessary... but i think it actually does a poor job of 3, because the subsystem ends up holding an OptionsValueContainer containing all of the options, rather than just the ones it might have wanted
witty-crayon-22786
12/06/2018, 8:57 PM...having said that, it's certainly easier to just have the OVC act as the options bucket, and not have to re-declare them
h
happy-kitchen-89482
12/07/2018, 2:19 AMAFAICT the subsystem instance has an OVC with only the values for the options it registered. What do you mean by “containing all of the options rather than just the ones it might have wanted”?
w
witty-crayon-22786
12/07/2018, 2:42 AMi think you're right. i came to the same conclusion
witty-crayon-22786
12/07/2018, 2:42 AMthe issue that i encountered in the first bout with https://github.com/pantsbuild/pants/pull/6872 though, was that useful eq/hash for OVC is harder than it should be
witty-crayon-22786
12/07/2018, 2:43 AMi still have it stashed somewhere, but.
witty-crayon-22786
12/07/2018, 2:43 AM1) nothing is sorted, 2) it's full of dict/set/list, etc