https://pantsbuild.org/ logo
#development
Title
# development
w

witty-crayon-22786

12/06/2018, 8:28 PM
1 and 2 are necessary... but i think it actually does a poor job of 3, because the subsystem ends up holding an OptionsValueContainer containing all of the options, rather than just the ones it might have wanted
...having said that, it's certainly easier to just have the OVC act as the options bucket, and not have to re-declare them
h

happy-kitchen-89482

12/07/2018, 2:19 AM
AFAICT the subsystem instance has an OVC with only the values for the options it registered. What do you mean by “containing all of the options rather than just the ones it might have wanted”?
w

witty-crayon-22786

12/07/2018, 2:42 AM
i think you're right. i came to the same conclusion
the issue that i encountered in the first bout with https://github.com/pantsbuild/pants/pull/6872 though, was that useful eq/hash for OVC is harder than it should be
i still have it stashed somewhere, but.
1) nothing is sorted, 2) it's full of dict/set/list, etc