https://pantsbuild.org/ logo
Join Slack
Powered by
<@U06A03HV1> Ok, I have a (messy) branch which swi...
# development
a
@witty-crayon-22786 Ok, I have a (messy) branch which switches over one grpc request from grpcio to tower… However, tower-grpc hasn’t been released yet, and it means we’d need to depend on unreleased versions of: tokio-connect tower-h2 tower-http tower-grpc tower-util From some watching I’ve been doing, they are breaking things internally from time to time, so we’d probably want to fork each of those repos, and pin their deps on each other I’m going to ask when they’re planning on releasing some things, but… How do you feel about ^^? I’m pretty excited to get rid of the C++ and openssl deps we currently have…
Ooh, 0.1 release with no API changes is next on his list after his current task, so… “soon”
a
does "soon" mean we would be able to depend on those crates without git soon, or just that the phase of no api changes is planned to occur soon?
a
API is already stable, release to crates soon
🔥 1
👌 1
a
i'm pumped to get rid of libraries that have to be installed differently on every machine in favor of rust crates
when the native work is done that won't be a plus but there's value to an ecosystem that cares about packaging things nicely (this can be created for c/c++ but someone has to do it)
a
FWIW crates are source distributions; they still get installed differently on every machine
a
right, but using 
pkg-config
shoves the burden of installing and maintaining the package onto the user, as opposed to the crate developer (is what i meant)
a
aha, you’re comparing rust crates to the horrible world of C++, rather than comparing rust crates to git-sourced dependencies?
💔 1
a
yes indeed
a
Yeah, it’s nice when it works 🙂
(It’s less nice when it doesn’t… Hi there crates whose build.rs file calls pkg-config…)
a
exactly!!!
if it calls 
pkg-config
without using the 
pkg-config
crate and/or without clearly specifying how to install the appropriate c/c++ library that is extraordinarily less nice
literally why i joined this company
a
@witty-crayon-22786 Should I push this forwards (starting with https://github.com/pantsbuild/pants/pull/7030) or hold off until a release has happened?
w
whoa, sorry... had totally missed this thread!
yes, i'd be in favor of this.
a
w
i don't expect it to affect the release, unless you're concerned with the effect on the remoting jobs
done
a
Can I get push permissions on them all too please? 🙂
w
@average-vr-56795: done
a
Thanks!
@witty-crayon-22786 https://github.com/pantsbuild/pants/pull/7030 now ready for review 🙂 I’ll send out the rest of the stack tomorrow
w
sec
a
No rush 🙂
Open in Slack
PreviousNext
Powered by