@aloof-angle-91616 I haven’t read enough to know yet, but… How much simpler would https://github.com/pantsbuild/pants/pull/7115 be if we forced API consumers to make things the right type to start with, rather than supporting
wrapper_type
?
a
aloof-angle-91616
01/23/2019, 7:02 PM
we wouldn't have to do the argument checking in
datatype.__new__
the comment on the bottom was that we could split that off
i can totally do that
it's probably fine to force people to provide tuples but it's boilerplate and the lines of code will be fewer because people won't have to remember whether they're using lists or tuples