https://pantsbuild.org/ logo
#development
Title
# development
a

aloof-angle-91616

01/27/2019, 3:45 AM
@average-vr-56795 i am currently converting a
bazel_protos::build::bazel::remote::execution::v2::ActionResult
to a
bazel_protos::remote_execution::ActionResult
as part of: (1) converting
ExecuteProcessRequest
to
bazel_protos::remote_execution::Action
to use the proto as the key in a new
Database
in the
Store
(done) (2) using
bazel_protos::remote_execution::ActionResult
to store process results in the new
Database
in the
Store
(done) (3) extracting
bazel_protos::remote_execution::ActionResult
into a
FallibleExecuteProcessResult
(using the code which was previously in
<http://remote.rs|remote.rs>
) so i can pull process results from the
Store
(done) (4) converting a
bazel_protos::build::bazel::remote::execution::v2::ActionResult
to a
bazel_protos::remote_execution::ActionResult
so that in our `CommandRunner`'s
.run
method (in
<http://remote.rs|remote.rs>
) we can lean on the extraction of process results done in (3) this seems to be ok, but i was wondering if doing the not-really-that-tedious-just-wondering work of converting the prost protobuf in
...::v2::ActionResult
to
bazel_protos::remote_execution::ActionResult
is what you would do, or if you would do it the other way around, or if there's a method i'm missing to do this conversion already, or if everything is all wrong
i'm mostly done with the conversion now and it wasn't that much code, just converting between protobuf fields