aloof-angle-91616
01/27/2019, 10:43 PMStore
use the v2::*
protobuf types, including e.g. bazel_protos::build::bazel::remote::execution::v2::Directory
. is that a useful cleanup (as long as they're the same bytes), or is that going to break other things if we do it right now?average-vr-56795
01/27/2019, 10:51 PMaverage-vr-56795
01/27/2019, 10:52 PMaloof-angle-91616
01/27/2019, 10:52 PMaloof-angle-91616
01/27/2019, 10:53 PMAction
and ActionResult
from the new protos)aloof-angle-91616
01/27/2019, 10:56 PM<http://remote.rs|remote.rs>
is still using bazel_protos::remote_execution::Action
, which is now not what we are using to store things in the ActionCache
(which i renamed to ActionSerializer
for some reason), so there's one tiny conversion necessary. but i think i can stay out of fs
from now on at leastaverage-vr-56795
01/27/2019, 10:57 PMaloof-angle-91616
01/27/2019, 10:57 PMaverage-vr-56795
01/27/2019, 10:58 PMaloof-angle-91616
01/27/2019, 10:58 PMaloof-angle-91616
01/27/2019, 10:59 PMaverage-vr-56795
01/27/2019, 10:59 PMaloof-angle-91616
01/27/2019, 11:00 PMbazel_protos::build::bazel::remote::execution::v2::Action
everywhere then?aloof-angle-91616
01/27/2019, 11:00 PMaloof-angle-91616
01/27/2019, 11:01 PM<http://remote.rs|remote.rs>
and would get us the goal of "not changing protos for Action
objects at all"average-vr-56795
01/27/2019, 11:02 PMaverage-vr-56795
01/27/2019, 11:05 PMaverage-vr-56795
01/27/2019, 11:05 PMaloof-angle-91616
01/27/2019, 11:05 PMaloof-angle-91616
01/27/2019, 11:06 PMaverage-vr-56795
01/27/2019, 11:06 PMaloof-angle-91616
01/27/2019, 11:07 PMStore
and avoid marshalling between proto types entirelyaloof-angle-91616
01/27/2019, 11:07 PM