https://pantsbuild.org/ logo
#development
Title
# development
a

aloof-angle-91616

02/10/2019, 8:40 PM
also @average-vr-56795 i believe you tweeted about this but i would be extremely comfortable with adding a clippy lint for
_
cases in
match
expressions, i would love to have an excuse to learn how to do that unless there are too many legitimate uses of
_
in the codebase somehow
a

average-vr-56795

02/11/2019, 9:21 AM
Funny story! I checked that there wasn't one, then decided to make one, and someone else did in parallel too: https://github.com/rust-lang/rust-clippy/pull/3652 My one is more fully featured (specifically, it suggests replacement code, which can be automatically applied, rather than just telling you that you have a problem), so I PR'd mine too, but I need to fix up some tests: https://github.com/rust-lang/rust-clippy/pull/3729 In the mean time, you can test it out by adding it to the list of enabled clippy lints in our codebase and switching to nightly rust. IIRC one module (I think graph?) has several to fix, but otherwise we're pretty clean
a

aloof-angle-91616

02/11/2019, 6:02 PM
wonderful!!!!
thank you for contributing this!
i will look up how to make our shell scripts switch to nightly rust
a

average-vr-56795

02/11/2019, 7:08 PM
echo -n nightly > rust-toolchain