also the query pipeline is potentially going to be next leve Pants #development

also the query pipeline is potentially going to be...

aloof-angle-91616

03/10/2019, 2:40 AM

also the query pipeline is potentially going to be next level, i'm thinking something like:

Copy code

> ./pants --query='changes_since master' --query='filter type=junit_tests' --query='dependencies transitive=True' --query='filter type=jar_library' my-random-3rdparty-jar-task ::

🔥 1

hundreds-father-404

03/10/2019, 2:48 AM

That’s so cool! My biggest push will be for making this easy to discover how to do, e.g. good examples like this on our site + easy way in CLI to find all the options for

query

Definitely a fan of unifying our goals to as few as possible.

aloof-angle-91616

03/10/2019, 2:50 AM

yes, the reason i like having them all be v2 rules as well is so we have a consistent set of concepts that apply in code and on the command line

aloof-angle-91616

03/10/2019, 2:50 AM

and like

--query

should have a generated help string i think with all the registered methods

hundreds-father-404

03/10/2019, 2:51 AM

What does that mean? I don’t follow why v2 would help here, as I’m not very familiar with v2

aloof-angle-91616

03/10/2019, 2:52 AM

right now

--owner-of

and

--changed-parent

and target specs on the command line are mutually exclusive, and then there are v1 tasks which will do things like

filter

and

dependees

and

paths

, and the difference between the options and the tasks is an exposed implementation detail

aloof-angle-91616

03/10/2019, 2:52 AM

there's nothing specific that v2 rules get us except dependency injection

aloof-angle-91616

03/10/2019, 2:53 AM

changes_since HEAD

gets converted to an

OwnersRequest

, which gets converted to

BuildFileAddresses

aloof-angle-91616

03/10/2019, 2:53 AM

and

owner_of file/path.py

gets converted to an

OwnersRequest

as well, and we don't have to reimplement that part

aloof-angle-91616

03/10/2019, 2:54 AM

so if someone wanted to add another method that highlights specific files which we want to find owners for

aloof-angle-91616

03/10/2019, 2:54 AM

they can (in the code) write a rule to convert to an

OwnersRequest

and use the same configuration that other methods do

aloof-angle-91616

03/10/2019, 2:54 AM

it's not like "this saves lives"

aloof-angle-91616

03/10/2019, 2:55 AM

but more that v2 rules allow centralizing logic in the large and small and that makes implementation of things (and extension by plugin developers) easier, and it's less likely they'll need to resort to monolithic v1 tasks with their own config/etc

👌 1

aloof-angle-91616

03/10/2019, 2:55 AM

which is what happens in the monorepo

aloof-angle-91616

03/10/2019, 2:55 AM

and that bitrots

aloof-angle-91616

03/10/2019, 2:56 AM

and having a 1:1 correspondence between objects that get passed between v2 rules and the different

--query

methods makes documentation easier

aloof-angle-91616

03/10/2019, 2:57 AM

no really obvious wins except that it's so much easier for me to write at least

Open in Slack

Previous Next