Did anyone know that

./pants -ltrace list 3rdparty:

now hangs forever?

-ltrace is what causes it? Do we anticipate end users will ever use that flag

@red-balloon-89377 has a PR that happens to fix it, so I’m not investigating too closely; we’re going to pick up his PR and get it merged 🙂

@witty-crayon-22786 can we include this in the RC or is it too late?

We will not be able to pick that logging change... it's big.

And pretty scary as well 🙂

Ah didn’t realize that’s what we’re talking about. Agreed let’s not cherry-pick

But I think

-ltrace

not working is... ok.

It works fine up until the engine gets torn down, at which point it hangs

mm, sidenote: was this with/without pantsd?

If it helps, I reliably get:

./pants -ltrace list 3rdparty:
...
TRACE] Acquired file lock `/home/jsirois/dev/pantsbuild/jsirois-pants/.pants.workdir.file_lock` after waiting 0.000s [1 attempts were required]
3rdparty:args4j
3rdparty:checkstyle
3rdparty:commons-lang
3rdparty:cucumber-java
3rdparty:easymock
3rdparty:gson
3rdparty:guava
3rdparty:guava-testlib
3rdparty:ivy
3rdparty:jansi
3rdparty:javax-activation
3rdparty:jaxb-api
3rdparty:jaxb-core
3rdparty:jaxb-impl
3rdparty:jsr305
3rdparty:junit
3rdparty:log4j
3rdparty:protobuf-2.4.1
3rdparty:protobuf-java
3rdparty:protobuf-test-import
3rdparty:scalatest
3rdparty:shapeless
3rdparty:slf4j-api
3rdparty:thrift
3rdparty:wire-runtime
DEBUG] releasing lock: <pants.process.lock.OwnerPrintingInterProcessFileLock object at 0x7feaa0019908>
TRACE] Unlocked and closed file lock open on `/home/jsirois/dev/pantsbuild/jsirois-pants/.pants.workdir.file_lock`

TRACE] shutdown; state=pool::State { lifecycle: Running, num_futures: 0 }
TRACE]   -> transitioned to shutdown
TRACE]   -> shutting down workers
FATAL: exception not rethrown
FATAL: exception not rethrown
FATAL: exception not rethrown
FATAL: exception not rethrown
FATAL: exception not rethrown
Aborted (core dumped)

Without 🙂 Just straight up V1 pants.

ew. maybe a shutdown ordering thing, where we end up trying to log after something important has already been dropped