<@UBV8BCQPJ> Expecting <https://github.com/pantsbu...
# developmenta
average-vr-56795
04/09/2019, 10:04 AM@red-balloon-89377 Expecting https://github.com/pantsbuild/pants/pull/6817 to go green - final review? 🙂
r
red-balloon-89377
04/09/2019, 10:28 AMMost comments are nits, and more than half comments that I left unresolved. I can fix them if you want 🙂
a
average-vr-56795
04/09/2019, 10:28 AMHurrah! I’m happy either way
r
red-balloon-89377
04/09/2019, 10:29 AMOkay, I have to sheperd an update for about 10 minutes, can fix the comments after
a
average-vr-56795
04/09/2019, 10:29 AMSounds good 🙂
r
red-balloon-89377
04/09/2019, 10:46 AMDo you have a handy repro for this: https://github.com/pantsbuild/pants/pull/6817#discussion_r273422195?
red-balloon-89377
04/09/2019, 10:47 AMOtherwise, comments addressed and pushed
a
average-vr-56795
04/09/2019, 11:26 AMMy take is that in pantsd that probably won’t show (not in pantsd it probably will), but that there’s nothing reasonable for us to do in that case (other than maybe writing to a hard-coded file named
/tmp/unhandled-pantsd-error