https://pantsbuild.org/ logo
#development
Title
# development
a

average-vr-56795

04/09/2019, 10:04 AM
@red-balloon-89377 Expecting https://github.com/pantsbuild/pants/pull/6817 to go green - final review? 🙂
r

red-balloon-89377

04/09/2019, 10:28 AM
Most comments are nits, and more than half comments that I left unresolved. I can fix them if you want 🙂
a

average-vr-56795

04/09/2019, 10:28 AM
Hurrah! I’m happy either way
r

red-balloon-89377

04/09/2019, 10:29 AM
Okay, I have to sheperd an update for about 10 minutes, can fix the comments after
a

average-vr-56795

04/09/2019, 10:29 AM
Sounds good 🙂
r

red-balloon-89377

04/09/2019, 10:46 AM
Otherwise, comments addressed and pushed
a

average-vr-56795

04/09/2019, 11:26 AM
My take is that in pantsd that probably won’t show (not in pantsd it probably will), but that there’s nothing reasonable for us to do in that case (other than maybe writing to a hard-coded file named
/tmp/unhandled-pantsd-error
or something)