The native `setup pantsd logger` requires that externs have

Question

The native `setup pantsd logger` requires that externs have been init d before it can be called this is done by initialising the memoized `native context` in Python Is there a good way to encode this dependency in code

average-vr-56795 · Answer

Right now I ve added a ` context = self context` to native py s `setup pantsd logger` but that feels much less good than actually passing a value somewhere

aloof-angle-91616 · Answer

what should `setup pantsd logger ` do if the externs haven t yet been initialized

average-vr-56795 · Answer

It panics

average-vr-56795 · Answer

Because it has no way of returning an error to the python if it doesn t have externs

aloof-angle-91616 · Answer

a contextmanager is what i m thinking of possibly at the site where `setup pantsd logger ` is called

average-vr-56795 · Answer

What would the contextmanager do

average-vr-56795 · Answer

Actually looking at it I suspect just the `Native` constructor should do the initialising that the `context` property currently does

aloof-angle-91616 · Answer

provide access to the Native instance and ensure the context is accessed before yielding it so whatever calls setup pantsd logger will be sure that the context is setup

aloof-angle-91616 · Answer

there s more initialization that needs to be moved around in that file too your suspicion is probably right

witty-crayon-22786 · Answer

moving the initialization out to the module level might work too ie rather than making Native a singleton via the class level stuff could make it a singleton as a static field in the module

witty-crayon-22786 · Answer

< average vr 56795> ^

average-vr-56795 · Answer

Ooh sounds good slightly smiling face Thanks

witty-crayon-22786 · Answer

in theory that could still fail to initialize but it would be preeetty hard

witty-crayon-22786 · Answer

since we do relatively little import time anything

average-vr-56795 · Answer

Yeah

witty-crayon-22786 · Answer

the only other obvious import time thing is ExceptionSink

aloof-angle-91616 · Answer

or ` rule` parsing but we try to keep that pretty slim

witty-crayon-22786 · Answer

mm

witty-crayon-22786 · Answer

speaking of which i wonder if we re triggering that during a RemotePantsRunner run

aloof-angle-91616 · Answer

we should be able to avoid it if we are doing that right now

witty-crayon-22786 · Answer

there is a lazy import that is supposed to avoid it but anyway

witty-crayon-22786 · Answer

later smiley

aloof-angle-91616 · Answer

then that probably works