<@U06A03HV1> <@UB2J9BQA0> is starting to bump into...
# developmenta
average-vr-56795
05/08/2019, 2:16 PM@witty-crayon-22786 @hundreds-father-404 is starting to bump into v2 target API problems, so we should probably sync up on those
h
hundreds-father-404
05/08/2019, 2:19 PMAgreed. I’m meeting with Stu today 11-11:30 to talk about V2
a
average-vr-56795
05/08/2019, 2:22 PMAwesome :)
h
hundreds-father-404
05/08/2019, 2:34 PMIs this still useful to read / up to date? https://docs.google.com/document/d/102EFbwk6cpM9-_4ZSYhMQYA0zL1UKbXzW-DCd8KsFeg/edit#
a
average-vr-56795
05/08/2019, 2:36 PMOh wow… No, that’s pretty old
average-vr-56795
05/08/2019, 2:36 PMI suspect there isn’t a huge amount of useful documentation anywhere except the code today…
average-vr-56795
05/08/2019, 2:36 PMhttps://github.com/pantsbuild/pants/issues/4535 has some context
h
hundreds-father-404
05/08/2019, 2:37 PMthat issue is how I found the doc
a
average-vr-56795
05/08/2019, 2:38 PMAha
average-vr-56795
05/08/2019, 2:38 PMYeah, just the first issue description has been updated to have some information; but I suspect because this is all in flux it’s mostly just in mine and Stu’s and Danny’s heads
h
hundreds-father-404
05/08/2019, 2:39 PMWhich is one of the reasons I’m really excited to be working on V2. All these things are new for me, and I’m hoping to be able to translate what I learn into some type of formal documentation
a
average-vr-56795
05/08/2019, 2:39 PM😄 That would be amazing!
average-vr-56795
05/08/2019, 2:39 PM(Though part of why it’s not currently documented is because of how in flux it is)
h
hundreds-father-404
05/08/2019, 2:41 PMWhich I was thinking about too. But I think that us writing out documentation will help us to think through our design and decide if we should change it. Also maybe easier to update out-of-date docs than to write them from scratch?
a
average-vr-56795
05/08/2019, 2:42 PMYeah, writing docs up front can definitely help frame design 🙂
👀 1
w
witty-crayon-22786
05/08/2019, 5:12 PMsome of that doc might still be useful, some of the comments on 4535 might still be useful
witty-crayon-22786
05/08/2019, 5:13 PMi have some more recent notes, but i ended up getting a bit lost in them this weekend, and needed to just dive in to make an incremental improvement
witty-crayon-22786
05/08/2019, 5:13 PMa big potential trap is just making sure we're ready for codegen. we proved that the engine makes it possible to do that in a very clean way, but it's very tied up in the target API
witty-crayon-22786
05/08/2019, 5:14 PMbut i mentioned to eric this morning that i think that to a large degree, we should be trying to just work around the target api for the length of the python test remoting project
witty-crayon-22786
05/08/2019, 5:15 PM(making improvements where obvious/helpful, but mostly doing a lot of set/get attr)
witty-crayon-22786
05/08/2019, 5:16 PMwe proved that the engine makes it possible to do that in a very clean way"we" being @enough-analyst-54434 and i, during the initial engine experiments
h
hundreds-father-404
05/08/2019, 5:39 PMAgreed. I’m going to be on the lookout for easy wins, but will try to refrain from blocking myself too much from major changes like populating None attributes
Once remoting is complete, I will have substantially more experience with V2 and then would love to work on direct V2 stuff though!
w
witty-crayon-22786
05/08/2019, 5:39 PM👍
a
aloof-angle-91616
05/08/2019, 7:10 PMi've been making quite a lot of github issues regarding the v2 engine, that seems to be a lower barrier to entry than making a whole doc unless we're pretty clear on the doc contents
👍 1
w
witty-crayon-22786
05/08/2019, 7:10 PMwe're not clear on the doc contents. but that's sometimes sortof-semi a reason to create a doc
witty-crayon-22786
05/08/2019, 7:11 PMwhen you have a large(r) problem that needs a cohesive solution
witty-crayon-22786
05/08/2019, 7:11 PMunknown.
witty-crayon-22786
05/08/2019, 7:12 PM(the fields externalization doc was a case of not iterating back and forth between implementation and design, i think... it shouldn't have ended up frozen in time like that. mea culpa)