an `@console_rule` can have a dependency on an `op...
# developmenta
aloof-angle-91616
05/14/2019, 2:13 AMan
@console_ruleoptionable_rule()h
hundreds-father-404
05/14/2019, 2:16 AMCurrently using
optionable_rule()--python-setup-interpreter-constraints--test-pytest-chroothundreds-father-404
05/14/2019, 2:16 AMI think the only way to consume task options is by defining them in the
Goala
aloof-angle-91616
05/14/2019, 2:36 AMoh i absolutely would make
--argsTestaloof-angle-91616
05/14/2019, 2:36 AMand please when you do make it a list option and use
pants.util.strutil.safe_shlex_split()aloof-angle-91616
05/14/2019, 2:37 AM(imho)
h
hundreds-father-404
05/14/2019, 2:40 AMWould that allow passthru syntax, or require using
—args./pants test.pytest ... — -k test_fooa
aloof-angle-91616
05/14/2019, 2:40 AMwell, it would be a way to get options to the pytest runner on the command line
aloof-angle-91616
05/14/2019, 2:41 AMi think you might need multiple changes to do that, but again, not as familiar with this as i could be
aloof-angle-91616
05/14/2019, 2:41 AMand maybe you could do this in the same change
aloof-angle-91616
05/14/2019, 2:41 AMpiping in passthru args might not be hard
aloof-angle-91616
05/14/2019, 2:42 AMi'll look in the impl for
.passthru_args()👍 1
h
hundreds-father-404
05/14/2019, 2:42 AMOkay. With some guidance, I’d love to work on passthru args. It’d be really helpful in porting to V2
a
aloof-angle-91616
05/14/2019, 2:43 AMoh no, this should totally work
aloof-angle-91616
05/14/2019, 2:44 AMoh no nvm it'll work though
aloof-angle-91616
05/14/2019, 2:44 AM.get_passthru_args()task.py👍 1
aloof-angle-91616
05/14/2019, 2:47 AMi think you could do subscoped options (unless that somehow already works, which would be radical) in one change, and passthru args in another
💯 1
aloof-angle-91616
05/14/2019, 2:48 AMbut they probably touch ~the same code
aloof-angle-91616
05/14/2019, 2:49 AMalso yeah with passthru args done like not sure how much more we need e.g. to support using the v2 pytest runner for all our python tests in our own CI?
aloof-angle-91616
05/14/2019, 2:49 AMi know we have more
aloof-angle-91616
05/14/2019, 2:49 AMjust seems close
h
hundreds-father-404
05/14/2019, 2:54 AMWe’re very close to V2 for unit tests in CI, after my 3 PRs land! (They’re sequential)
- support for source roots https://github.com/pantsbuild/pants/pull/7696
- then will push a fix to transitive deps
- then will push a few fixes to get the util folder completely green. Have to set up the
env💵 1
hundreds-father-404
05/14/2019, 2:55 AMReview of that first PR would be awesome. It blocks everything else
w
witty-crayon-22786
05/14/2019, 3:42 AMyea, passthru would require some additional effort. temporarily putting the options on a subsystem would be reasonable workaround i think.